You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/18 22:52:40 UTC

Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40453/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3753
    https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
-------

Tests that reinitiailize SSL configuration only change environment variables upon setup.  This means the changed environment will stay intact after the test.  This may lead to unexpected results in subsequent tests.


Diffs
-----

  3rdparty/libprocess/include/process/ssl/gtest.hpp 54885ec359df947f6d31375d4c2a32cae587f845 

Diff: https://reviews.apache.org/r/40453/diff/


Testing
-------

See next review.


Thanks,

Joseph Wu


Re: Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40453/#review108345
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40453/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3753
>     https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tests that reinitiailize SSL configuration only change environment variables upon setup.  This means the changed environment will stay intact after the test.  This may lead to unexpected results in subsequent tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 54885ec359df947f6d31375d4c2a32cae587f845 
> 
> Diff: https://reviews.apache.org/r/40453/diff/
> 
> 
> Testing
> -------
> 
> See next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40453/#review108374
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Schlicht


On Nov. 30, 2015, 7:15 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40453/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 7:15 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3975
>     https://issues.apache.org/jira/browse/MESOS-3975
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tests that reinitiailize SSL configuration only change environment variables upon setup.  This means the changed environment will stay intact after the test.  This may lead to unexpected results in subsequent tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 95e19845f90f648b148a39e7791eb4d4df939876 
> 
> Diff: https://reviews.apache.org/r/40453/diff/
> 
> 
> Testing
> -------
> 
> See next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40453/
-----------------------------------------------------------

(Updated Nov. 30, 2015, 10:15 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Till Toenshoff.


Changes
-------

Rebase!


Bugs: MESOS-3975
    https://issues.apache.org/jira/browse/MESOS-3975


Repository: mesos


Description
-------

Tests that reinitiailize SSL configuration only change environment variables upon setup.  This means the changed environment will stay intact after the test.  This may lead to unexpected results in subsequent tests.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/ssl/gtest.hpp 95e19845f90f648b148a39e7791eb4d4df939876 

Diff: https://reviews.apache.org/r/40453/diff/


Testing
-------

See next review.


Thanks,

Joseph Wu


Re: Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40453/#review108331
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40453/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3753
>     https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tests that reinitiailize SSL configuration only change environment variables upon setup.  This means the changed environment will stay intact after the test.  This may lead to unexpected results in subsequent tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 54885ec359df947f6d31375d4c2a32cae587f845 
> 
> Diff: https://reviews.apache.org/r/40453/diff/
> 
> 
> Testing
> -------
> 
> See next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>