You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/11/10 13:34:22 UTC
DO NOT REPLY [Bug 118595] New: IP clearance: Remove glibc
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Bug #: 118595
Issue Type: DEFECT
Summary: IP clearance: Remove glibc
Classification: Code
Product: external
Version: OOO340m0
Platform: PC
OS/Version: Windows 7
Status: NEW
Severity: enhancement
Priority: P5
Component: www
AssignedTo: st@openoffice.org
ReportedBy: af@a-w-f.de
CC: ooo-issues@incubator.apache.org
The glibc library has LGPL license, which is incompatible with Apache license.
Therefore the glibc directory has to be removed from the "external" module.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
--- Comment #1 from Andre <af...@a-w-f.de> 2011-11-11 12:22:48 UTC ---
Good news. It looks like removing glibc will improve the code base. It
provides two sets of functions, getopt() for parsing command lines and the
readdir family for reading the contents of directories.
The getopt() function is used in two places: idlc, which is about to be removed
for issue 118568, and rscdep, where it is used incorrectly. Removing its used
from rscdep will improve that program.
The family of readdir functions is not used at all an non Unix like operation
systems. On Windows the similar family of findfirst functions is used instead.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
--- Comment #6 from Pedro Giffuni <pf...@apache.org> 2011-11-15 16:14:43 UTC ---
I made a partial commit of this.
The glibc dependency remains until the idlc preproc is updated
but at least we can test the rest of this patch for now.
svn commit -m "i118595 - Removal of the use of getopt() from rscdep. Patch by
Andre."
Sending tools/Executable_rscdep.mk
Sending tools/bootstrp/rscdep.cxx
Transmitting file data ..
Committed revision 1202270.
Thanks!
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Andre <af...@a-w-f.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #7 from Andre <af...@a-w-f.de> 2011-12-02 12:33:49 UTC ---
Commited the rest of the glibc removal.
SVN revision is 1209447.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
--- Comment #5 from Pedro Giffuni <pf...@apache.org> 2011-11-14 07:08:01 UTC ---
(In reply to comment #4)
> > The getopt() function is used in two places: idlc, which is about to be removed
> > for issue 118568, and rscdep, where it is used incorrectly. Removing its used
> > from rscdep will improve that program.
> >
>
Nevermind ... I opengroked it and you are right, the only occurence of
getopt() there will go.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
hdu@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
CC| |hdu@apache.org
--- Comment #8 from hdu@apache.org 2012-01-30 13:32:09 UTC ---
Closing resolved issue.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Andre <af...@a-w-f.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Blocks| |118566
OS/Version|Windows 7 |All
Severity|enhancement |blocker
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
--- Comment #3 from Andre <af...@a-w-f.de> 2011-11-11 13:19:00 UTC ---
Created attachment 76998
--> https://issues.apache.org/ooo/attachment.cgi?id=76998
Remove local copy of glibc and its use.
Removal of glibc from the external module.
Removal of the use of getopt() from rscdep.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Andre <af...@a-w-f.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |118568
--- Comment #2 from Andre <af...@a-w-f.de> 2011-11-11 12:24:27 UTC ---
Added issue 118568 as prerequisite, because idlc has to be removed before glibc
can be removed.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Bug 118595 depends on bug 118568, which changed state.
Bug 118568 Summary: replace lcc based preprocessor with ucpp
https://issues.apache.org/ooo/show_bug.cgi?id=118568
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |OBSOLETE
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Oliver-Rainer Wittmann <or...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|st@openoffice.org |af@a-w-f.de
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118595] IP clearance: Remove glibc
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118595
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pfg@apache.org
--- Comment #4 from Pedro Giffuni <pf...@apache.org> 2011-11-13 23:29:39 UTC ---
(In reply to comment #1)
> Good news. It looks like removing glibc will improve the code base. It
> provides two sets of functions, getopt() for parsing command lines and the
> readdir family for reading the contents of directories.
>
> The getopt() function is used in two places: idlc, which is about to be removed
> for issue 118568, and rscdep, where it is used incorrectly. Removing its used
> from rscdep will improve that program.
>
My understanding is idlc will remain and that only the preprocessor will be
replaced with a smaller and more portable.
We did find this portable implementation from OpenBSD if you need it:
http://cgit.freedesktop.org/mesa/mesa/tree/src/getopt
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.