You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/22 01:16:46 UTC
Review Request 20540: Patch for KAFKA-1410
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1410
https://issues.apache.org/jira/browse/KAFKA-1410
Repository: kafka
Description
-------
1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
Diffs
-----
core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
Diff: https://reviews.apache.org/r/20540/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Jun Rao <ju...@gmail.com>.
> On April 22, 2014, 12:07 a.m., Guozhang Wang wrote:
> > This patch is much larger than it is claimed to be :) Any rebasing missed here?
It picked up the remaining followup change in kafka-1356: basically moving the locking/live broker list inside MetadataCache.
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review40980
-----------------------------------------------------------
On April 22, 2014, 8:51 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20540/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 8:51 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1410
> https://issues.apache.org/jira/browse/KAFKA-1410
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Handle the creation of OffsetTopic properly.
>
>
> 1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
>
>
> 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
> core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
> core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
> core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
>
> Diff: https://reviews.apache.org/r/20540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review40980
-----------------------------------------------------------
This patch is much larger than it is claimed to be :) Any rebasing missed here?
- Guozhang Wang
On April 21, 2014, 11:16 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20540/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:16 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1410
> https://issues.apache.org/jira/browse/KAFKA-1410
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
> core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
> core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
>
> Diff: https://reviews.apache.org/r/20540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Jun Rao <ju...@gmail.com>.
> On April 22, 2014, 6:26 p.m., Timothy Chen wrote:
> > core/src/main/scala/kafka/server/KafkaApis.scala, line 713
> > <https://reviews.apache.org/r/20540/diff/2/?file=564573#file564573line713>
> >
> > Do we no longer need to check for offset management topic?
Good catch. Fixed.
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review41039
-----------------------------------------------------------
On April 22, 2014, 8:51 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20540/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 8:51 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1410
> https://issues.apache.org/jira/browse/KAFKA-1410
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Handle the creation of OffsetTopic properly.
>
>
> 1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
>
>
> 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
> core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
> core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
> core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
>
> Diff: https://reviews.apache.org/r/20540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review41039
-----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20540/#comment74401>
Do we no longer need to check for offset management topic?
- Timothy Chen
On April 22, 2014, 4:37 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20540/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 4:37 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1410
> https://issues.apache.org/jira/browse/KAFKA-1410
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
>
>
> 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
> core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
> core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
> core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
>
> Diff: https://reviews.apache.org/r/20540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review41071
-----------------------------------------------------------
Ship it!
- Joel Koshy
On April 22, 2014, 8:51 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20540/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 8:51 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1410
> https://issues.apache.org/jira/browse/KAFKA-1410
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Handle the creation of OffsetTopic properly.
>
>
> 1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
>
>
> 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
> core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
> core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
> core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
>
> Diff: https://reviews.apache.org/r/20540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review41067
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On April 22, 2014, 8:51 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20540/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 8:51 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1410
> https://issues.apache.org/jira/browse/KAFKA-1410
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Handle the creation of OffsetTopic properly.
>
>
> 1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
>
>
> 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
> core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
> core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
> core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
>
> Diff: https://reviews.apache.org/r/20540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/
-----------------------------------------------------------
(Updated April 22, 2014, 8:51 p.m.)
Review request for kafka.
Bugs: KAFKA-1410
https://issues.apache.org/jira/browse/KAFKA-1410
Repository: kafka
Description (updated)
-------
1. Handle the creation of OffsetTopic properly.
1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
Diffs (updated)
-----
core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
Diff: https://reviews.apache.org/r/20540/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20540: Patch for KAFKA-1410
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/
-----------------------------------------------------------
(Updated April 22, 2014, 4:37 p.m.)
Review request for kafka.
Bugs: KAFKA-1410
https://issues.apache.org/jira/browse/KAFKA-1410
Repository: kafka
Description (updated)
-------
1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if the controller epoch is old.
1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic metadata request to ReplicaManager.
Diffs (updated)
-----
core/src/main/scala/kafka/server/KafkaApis.scala 1a4ffcea37e32739b8360956b4a40c0101b97822
core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION
core/src/main/scala/kafka/server/ReplicaManager.scala 5588f59783d5cd8f074263c207045625282af12d
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25
Diff: https://reviews.apache.org/r/20540/diff/
Testing
-------
Thanks,
Jun Rao