You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by rerngvit <gi...@git.apache.org> on 2016/06/08 17:17:36 UTC
[GitHub] incubator-zeppelin pull request #977: [ZEPPELIN-911] Apply new mechanism to ...
GitHub user rerngvit opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/977
[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
### What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
### How should this be tested?
1. apply patch
2. rm -r interpreter/flink
3. rm conf/interpreter.json
4. mvn clean package -DskipTests -pl flink
5. bin/zeppelin-daemon.sh start
6. run some paragraph with simple Flink queries
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerngvit/incubator-zeppelin ZEPPELIN-911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/977.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #977
----
commit 55d19210415c6d46c96ec7186cea3ddb9b028f11
Author: rerngvit <re...@kth.se>
Date: 2016-06-08T16:53:41Z
[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
### How should this be tested?
1. apply patch
2. rm -r interpreter/flink
3. rm conf/interpreter.json
4. mvn clean package -DskipTests -pl flink
5. bin/zeppelin-daemon.sh start
6. run some paragraph with simple Flink queries
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #977: [ZEPPELIN-911] Apply new mechanism to FlinkIn...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/977
Looks great to me, @rerngvit thank you for contribution!
Have update JIRA issues assignment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #977: [ZEPPELIN-911] Apply new mechanism to ...
Posted by rerngvit <gi...@git.apache.org>.
GitHub user rerngvit reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/977
[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
### How should this be tested?
1. apply patch
2. rm -r interpreter/flink
3. rm conf/interpreter.json
4. mvn clean package -DskipTests -pl flink
5. bin/zeppelin-daemon.sh start
6. run some paragraph with simple Flink queries
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerngvit/incubator-zeppelin ZEPPELIN-911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/977.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #977
----
commit 55d19210415c6d46c96ec7186cea3ddb9b028f11
Author: rerngvit <re...@kth.se>
Date: 2016-06-08T16:53:41Z
[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
### How should this be tested?
1. apply patch
2. rm -r interpreter/flink
3. rm conf/interpreter.json
4. mvn clean package -DskipTests -pl flink
5. bin/zeppelin-daemon.sh start
6. run some paragraph with simple Flink queries
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #977: [ZEPPELIN-911] Apply new mechanism to ...
Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #977: [ZEPPELIN-911] Apply new mechanism to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #977: [ZEPPELIN-911] Apply new mechanism to FlinkIn...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/977
I've tested it and worked well. LGTM. Merging if there's no more discussion. @rerngvit Could you please your jira id? I cannot assign you as a contributor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #977: [ZEPPELIN-911] Apply new mechanism to ...
Posted by rerngvit <gi...@git.apache.org>.
GitHub user rerngvit reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/977
[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
### How should this be tested?
1. apply patch
2. rm -r interpreter/flink
3. rm conf/interpreter.json
4. mvn clean package -DskipTests -pl flink
5. bin/zeppelin-daemon.sh start
6. run some paragraph with simple Flink queries
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerngvit/incubator-zeppelin ZEPPELIN-911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/977.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #977
----
commit 55d19210415c6d46c96ec7186cea3ddb9b028f11
Author: rerngvit <re...@kth.se>
Date: 2016-06-08T16:53:41Z
[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
### How should this be tested?
1. apply patch
2. rm -r interpreter/flink
3. rm conf/interpreter.json
4. mvn clean package -DskipTests -pl flink
5. bin/zeppelin-daemon.sh start
6. run some paragraph with simple Flink queries
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #977: [ZEPPELIN-911] Apply new mechanism to ...
Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---