You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rob-close <gi...@git.apache.org> on 2016/06/08 19:04:07 UTC
[GitHub] cordova-plugin-whitelist pull request #21: CB 11391
GitHub user rob-close opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/21
CB 11391
Originaly was trying to correct this sonarqube complaint:
"Correctness - Suspicious reference comparison of Boolean values"
I failed to notice that the condition can be one of three states:
true, false, or null.
The original code was valid. Undoing my change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob-close/cordova-plugin-whitelist CB-11391
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-whitelist/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit 9e8eeb9d882ca035056482e773fe86fc38c228c3
Author: Rob Close <ro...@sap.com>
Date: 2016-06-07T19:56:18Z
CB-113 android: Does not pass sonarqube scan
The problem is "Correctness - Suspicious reference comparison of Boolean values",
which sonarqube considers major.
commit 31b0d6faed875706b6e9d5b0317cd43760630b89
Author: Rob Close <ro...@sap.com>
Date: 2016-06-08T18:58:27Z
CB-11391 android: Does not pass sonarqube scan
Originaly was trying to correct this sonarqube complaint:
"Correctness - Suspicious reference comparison of Boolean values"
I failed to notice that the condition can be one of three states:
true, false, or null.
The original code was valid. Undoing my change.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request #21: CB-11391 android: Does not pass s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org