[beam] branch master updated: [BEAM-9026] Avoid side effects from positional value provider arguments.

[ib...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ibzib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 52698a4  [BEAM-9026] Avoid side effects from positional value provider arguments.
     new ad2d778  Merge pull request #12989 from ibzib/BEAM-9026
52698a4 is described below

commit 52698a42084100b70cebeb867925859b1c583ec0
Author: Kyle Weaver <kc...@google.com>
AuthorDate: Thu Oct 1 09:36:14 2020 -0700

    [BEAM-9026] Avoid side effects from positional value provider arguments.
    
    This doesn't address the root cause of this issue, which is that value provider arguments are still leaking into unrelated tests.
---
 .../apache_beam/runners/portability/flink_uber_jar_job_server_test.py   | 2 +-
 .../apache_beam/runners/portability/spark_uber_jar_job_server_test.py   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sdks/python/apache_beam/runners/portability/flink_uber_jar_job_server_test.py b/sdks/python/apache_beam/runners/portability/flink_uber_jar_job_server_test.py
index 0e812a7..591f2db 100644
--- a/sdks/python/apache_beam/runners/portability/flink_uber_jar_job_server_test.py
+++ b/sdks/python/apache_beam/runners/portability/flink_uber_jar_job_server_test.py
@@ -184,7 +184,7 @@ class FlinkUberJarJobServerTest(unittest.TestCase):
 
   def test_retain_unknown_options(self):
     original_options = pipeline_options.PipelineOptions(
-        ['--unknown_option_foo', 'some_value'])
+        ['--unknown_option_foo=some_value'])
     flink_options = original_options.view_as(
         pipeline_options.FlinkRunnerOptions)
     flink_options.flink_submit_uber_jar = True
diff --git a/sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py b/sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py
index 3ae25d4..0a7b954 100644
--- a/sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py
+++ b/sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py
@@ -213,7 +213,7 @@ class SparkUberJarJobServerTest(unittest.TestCase):
                        ])
 
   def test_retain_unknown_options(self):
-    original_options = PipelineOptions(['--unknown_option_foo', 'some_value'])
+    original_options = PipelineOptions(['--unknown_option_foo=some_value'])
     spark_options = original_options.view_as(SparkRunnerOptions)
     spark_options.spark_submit_uber_jar = True
     spark_options.spark_rest_url = 'spark://localhost:6066'