svn commit: r732185 - /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListener.java

[jw...@apache.org]

Author: jwaldman
Date: Tue Jan  6 16:16:42 2009
New Revision: 732185

URL: http://svn.apache.org/viewvc?rev=732185&view=rev
Log:
TRINIDAD-1359 filedownloadactionlistener firefox long filename is truncated
put quotes around the filename that is set in the Content-Disposition--
 hsr.setHeader("Content-Disposition", "attachment; filename=\""+encodeHTTPHeaderFilename + "\"");]

trunk

Modified:
    myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListener.java

Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListener.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListener.java?rev=732185&r1=732184&r2=732185&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListener.java (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListener.java Tue Jan  6 16:16:42 2009
@@ -110,8 +110,11 @@
           if (agentName.contains("msie") || agentName.contains("applewebkit") || agentName.contains("safari"))
             isGecko = false;
           // boolean isIE = CoreRenderer.isIE(RenderingContext.getCurrentInstance());
+          String encodeHTTPHeaderFilename = MimeUtility.encodeHTTPHeader(filename, !isGecko);
+          // double quotes are needed in case the filename is long. otherwise the filename gets
+          // truncated in Firefox.
           hsr.setHeader("Content-Disposition",
-                        "attachment; filename=" + MimeUtility.encodeHTTPHeader(filename, !isGecko));
+                        "attachment; filename=\""+encodeHTTPHeaderFilename + "\"");
         }
 
         MethodBinding method = getMethod();