You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/07 20:28:10 UTC

[GitHub] [lucene] mayya-sharipova commented on pull request #364: LUCENE-10154 NumericLeafComparator to define getPointValues

mayya-sharipova commented on pull request #364:
URL: https://github.com/apache/lucene/pull/364#issuecomment-938131414


   @jpountz Thank you for your feedback. I've addressed your comments in c4814f248b976ae2ae23173fc27319cb69d1c17d.  This is ready for another round of review. 
   
   > I think there is also a NumericComparator in the lucene/expressions module that needs to be updated?
   
   Indeed, good comment. `ExpressionValueSource` extends `DoubleValuesSource`, `DoubleValuesSource` was updated to return `null` for points in c4814f248b976ae2ae23173fc27319cb69d1c17d.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org