You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/26 20:13:33 UTC

[GitHub] [spark] amaliujia commented on pull request #38392: [SPARK-40914][CONNECT] Mark org/apache/spark/sql/connect to be private

amaliujia commented on PR #38392:
URL: https://github.com/apache/spark/pull/38392#issuecomment-1292601644

   Thanks everyone. I choose to apply the suggestion that mark the entire server module as private. The server implementation shouldn't be public API anyway. Only proto and DataFrames in clients are public API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org