You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/09/10 09:23:18 UTC
[PR] [Subscription] Suppress expected commit progress warnings [iotdb]
Caideyipi opened a new pull request, #18615:
URL: https://github.com/apache/iotdb/pull/18615
## Description
DataNodes with `subscription_enabled=false` intentionally return `UNSUPPORTED_OPERATION` when
ConfigNode pulls commit progress. The best-effort synchronizer already ignores their progress but
then logs the expected response as a warning.
Suppress that expected status in the best-effort response loop. Other unsuccessful responses still
produce warnings, and required synchronization still rejects `UNSUPPORTED_OPERATION`.
## Validation
- `mvn spotless:apply -pl iotdb-core/confignode`
- `mvn -o test -pl iotdb-core/confignode -am -Dtest=CommitProgressSyncProcedureTest -Dsurefire.failIfNoSpecifiedTests=false -Ddevelocity.off=true`
The focused test covers expected and unexpected responses, required synchronization, and persistence
of progress from successful DataNodes.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
- `CommitProgressSyncProcedure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Subscription] Suppress expected commit progress warnings [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18615:
URL: https://github.com/apache/iotdb/pull/18615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org