You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by to...@apache.org on 2018/03/22 13:26:59 UTC
svn commit: r1827486 - in /jackrabbit/oak/trunk/oak-solr-core/src:
main/java/org/apache/jackrabbit/oak/plugins/index/solr/query/
test/java/org/apache/jackrabbit/oak/plugins/index/solr/configuration/
test/java/org/apache/jackrabbit/oak/plugins/index/sol...
Author: tommaso
Date: Thu Mar 22 13:26:58 2018
New Revision: 1827486
URL: http://svn.apache.org/viewvc?rev=1827486&view=rev
Log:
OAK-7375 - fixed JCR full text operators parsing, removed unused imports in test
Modified:
jackrabbit/oak/trunk/oak-solr-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/solr/query/FilterQueryParser.java
jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/configuration/DefaultAnalyzersConfigurationTest.java
jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/query/SolrIndexIT.java
Modified: jackrabbit/oak/trunk/oak-solr-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/solr/query/FilterQueryParser.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-solr-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/solr/query/FilterQueryParser.java?rev=1827486&r1=1827485&r2=1827486&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-solr-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/solr/query/FilterQueryParser.java (original)
+++ jackrabbit/oak/trunk/oak-solr-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/solr/query/FilterQueryParser.java Thu Mar 22 13:26:58 2018
@@ -290,10 +290,13 @@ class FilterQueryParser {
public boolean visit(FullTextOr or) {
fullTextString.append('(');
for (int i = 0; i < or.list.size(); i++) {
+ FullTextExpression e = or.list.get(i);
+ if (e.toString().equals("\"OR\"")) {
+ continue;
+ }
if (i > 0 && i < or.list.size()) {
fullTextString.append(" OR ");
}
- FullTextExpression e = or.list.get(i);
String orTerm = parseFullTextExpression(e, configuration);
fullTextString.append(orTerm);
}
@@ -311,10 +314,13 @@ class FilterQueryParser {
public boolean visit(FullTextAnd and) {
fullTextString.append('(');
for (int i = 0; i < and.list.size(); i++) {
+ FullTextExpression e = and.list.get(i);
+ if (e.toString().equals("\"AND\"")) {
+ continue;
+ }
if (i > 0 && i < and.list.size()) {
fullTextString.append(" AND ");
}
- FullTextExpression e = and.list.get(i);
String andTerm = parseFullTextExpression(e, configuration);
fullTextString.append(andTerm);
}
Modified: jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/configuration/DefaultAnalyzersConfigurationTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/configuration/DefaultAnalyzersConfigurationTest.java?rev=1827486&r1=1827485&r2=1827486&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/configuration/DefaultAnalyzersConfigurationTest.java (original)
+++ jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/configuration/DefaultAnalyzersConfigurationTest.java Thu Mar 22 13:26:58 2018
@@ -16,7 +16,6 @@
*/
package org.apache.jackrabbit.oak.plugins.index.solr.configuration;
-import java.io.Reader;
import java.io.StringReader;
import java.util.regex.Pattern;
@@ -30,7 +29,6 @@ import org.apache.lucene.analysis.path.P
import org.apache.lucene.analysis.pattern.PatternCaptureGroupTokenFilter;
import org.apache.lucene.analysis.pattern.PatternReplaceFilter;
import org.apache.lucene.analysis.reverse.ReverseStringFilter;
-import org.apache.lucene.util.Version;
import org.junit.Before;
import org.junit.Test;
Modified: jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/query/SolrIndexIT.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/query/SolrIndexIT.java?rev=1827486&r1=1827485&r2=1827486&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/query/SolrIndexIT.java (original)
+++ jackrabbit/oak/trunk/oak-solr-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/solr/query/SolrIndexIT.java Thu Mar 22 13:26:58 2018
@@ -410,6 +410,30 @@ public class SolrIndexIT extends Abstrac
}
@Test
+ public void testFulltextOperators() throws Exception {
+ Tree test = root.getTree("/").addChild("test");
+ test.addChild("a").setProperty("text", "the lazy fox jumped over the brown dog");
+ test.addChild("b").setProperty("text", "the lazy bones raised to eat a dog");
+ root.commit();
+
+ assertQuery(
+ "/jcr:root//*[jcr:contains(., 'lazy AND brown')]",
+ "xpath", ImmutableList.of("/test/a"));
+
+ assertQuery(
+ "/jcr:root//*[jcr:contains(., 'lazy OR eat')]",
+ "xpath", ImmutableList.of("/test/a", "/test/b"));
+
+ assertQuery(
+ "/jcr:root//*[jcr:contains(., 'lazy AND bones')]",
+ "xpath", ImmutableList.of("/test/b"));
+
+ assertQuery(
+ "/jcr:root//*[jcr:contains(., 'lazy OR dog')]",
+ "xpath", ImmutableList.of("/test/a", "/test/b"));
+ }
+
+ @Test
public void containsPath() throws Exception {
Tree test = root.getTree("/").addChild("test");