[GitHub] [superset] eschutho commented on a change in pull request #19228: fix: add a new dataset on existing dataset updates if the new one doesn't exist

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #19228:
URL: https://github.com/apache/superset/pull/19228#discussion_r828551679



##########
File path: superset/connectors/sqla/models.py
##########
@@ -1834,11 +1835,20 @@ def update_table(  # pylint: disable=unused-argument
 
         session.execute(update(SqlaTable).where(SqlaTable.id == target.table.id))
 
-        # update ``Column`` model as well
         dataset = (
-            session.query(NewDataset).filter_by(sqlatable_id=target.table.id).one()

Review comment:
       This is where the error was found, but I updated all of the instances where the dataset should be updated in this file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org