You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/10/13 04:48:30 UTC
[PR] GH-44368: [C++] Use "lib" for generating bundled dependencies even with "clang-cl" [arrow]
kou opened a new pull request, #44391:
URL: https://github.com/apache/arrow/pull/44391
### Rationale for this change
We need to use "clang-cl" for Windows ARM64. We can use MSVC tool such as "lib" for generating bundled dependencies with "clang-cl" build because it's a MSVC like build.
### What changes are included in this PR?
Prefer "lib" to `${CMAKE_AR}` with "clang-cl" for generating bundled dependencies. It seems that `${CMAKE_AR}` doesn't generate `arrow_bundled_dependencies.lib`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44368: [C++] Use "lib" for generating bundled dependencies even with "clang-cl" [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44391:
URL: https://github.com/apache/arrow/pull/44391#issuecomment-2408822545
:warning: GitHub issue #44368 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44368: [C++] Use "lib" for generating bundled dependencies even with "clang-cl" [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #44391:
URL: https://github.com/apache/arrow/pull/44391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44368: [C++] Use "lib" for generating bundled dependencies even with "clang-cl" [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44391:
URL: https://github.com/apache/arrow/pull/44391#issuecomment-2417201832
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8973278984eaf9ccee1c83d0bb1846a4e217a7b3.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/31625534069) has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44368: [C++] Use "lib" for generating bundled dependencies even with "clang-cl" [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44391:
URL: https://github.com/apache/arrow/pull/44391#issuecomment-2415801893
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org