You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/03 12:16:04 UTC

[jira] [Commented] (METRON-915) platform_info script should have node and npm version

    [ https://issues.apache.org/jira/browse/METRON-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994743#comment-15994743 ] 

ASF GitHub Bot commented on METRON-915:
---------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/incubator-metron/pull/562

    METRON-915 add node and npm to platform_info.sh

    ## Contributor Comments
    Now that we depend on node and npm, put them into the platform_info.sh for troubleshooting build failures.
    
    We may want to follow on with the pr template?
    
    to verify.. run the script on platforms you use
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ NA] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [NA ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [ NA] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [NA ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [NA ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/incubator-metron METRON-915

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #562
    
----
commit f7951ea1a55bf7d0b368bbf9e2121e65f39ab4dc
Author: Otto Fowler <ot...@gmail.com>
Date:   2017-05-03T12:12:26Z

    add node and npm to platform_info.sh

----


> platform_info script should have node and npm version
> -----------------------------------------------------
>
>                 Key: METRON-915
>                 URL: https://issues.apache.org/jira/browse/METRON-915
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>
> Now that node and npm are required for the build, platform_info.sh should have their versions present for troubleshooting.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)