You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/17 13:05:27 UTC
[GitHub] [incubator-hudi] baobaoyeye opened a new pull request #1527:
[MINOR] fix some places are not elegant, as a newcomer
baobaoyeye opened a new pull request #1527: [MINOR] fix some places are not elegant, as a newcomer
URL: https://github.com/apache/incubator-hudi/pull/1527
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
1. fix toString of InsertBucket
2. fix inelegant code of pattern like "if not null" in RollbackHelper
3. fix regex bug in HoodieArchivedTimeline
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
yes
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken merged pull request #1527: [MINOR] use
Option and fix description in toString method
Posted by GitBox <gi...@apache.org>.
lamber-ken merged pull request #1527: [MINOR] use Option and fix description in toString method
URL: https://github.com/apache/incubator-hudi/pull/1527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1527: [MINOR] fix
some places are not elegant, as a newcomer
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1527: [MINOR] fix some places are not elegant, as a newcomer
URL: https://github.com/apache/incubator-hudi/pull/1527#issuecomment-615501557
LGTM, thanks @baobaoyeye
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1527: [MINOR] fix some
places are not elegant, as a newcomer
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1527: [MINOR] fix some places are not elegant, as a newcomer
URL: https://github.com/apache/incubator-hudi/pull/1527#issuecomment-615522191
Please merge @lamber-ken, and how about changing the title to `[MINOR] use Option and fix description in toString method `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request
#1527: [MINOR] fix some places are not elegant, as a newcomer
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1527: [MINOR] fix some places are not elegant, as a newcomer
URL: https://github.com/apache/incubator-hudi/pull/1527#discussion_r410505797
##########
File path: hudi-client/src/main/java/org/apache/hudi/table/action/commit/InsertBucket.java
##########
@@ -32,10 +32,10 @@
@Override
public String toString() {
- final StringBuilder sb = new StringBuilder("WorkloadStat {");
+ final StringBuilder sb = new StringBuilder("InsertBucket {");
Review comment:
Good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1527: [MINOR] fix
some places are not elegant, as a newcomer
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1527: [MINOR] fix some places are not elegant, as a newcomer
URL: https://github.com/apache/incubator-hudi/pull/1527#issuecomment-615559297
> Please merge @lamber-ken, and how about changing the title to `[MINOR] use Option and fix description in toString method `?
Got, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services