You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/03/02 04:11:41 UTC
[GitHub] [knox] Flamingo93 opened a new pull request #541: KNOX-2711 - Add trino ui support in service definition.
Flamingo93 opened a new pull request #541:
URL: https://github.com/apache/knox/pull/541
## What changes were proposed in this pull request?
[Trino](https://trino.io/docs/current/) is a distributed SQL query engine designed to query large data sets distributed over one or more heterogeneous data sources. We can support it in knox service definition, so that knox can proivide proxying service for it.
## How was this patch tested?
Deploy knox in a cluster with trino, we can access trino ui with knox server port 8443.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #541:
URL: https://github.com/apache/knox/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1057274206
@Flamingo93 - the screenshot you attached does not show proof that Trino UI is accessible via Knox (https://trino_ui_host:9084/ui). Could you please attach the correct one?
Cc. @moresandeep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on a change in pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on a change in pull request #541:
URL: https://github.com/apache/knox/pull/541#discussion_r818007439
##########
File path: gateway-service-definitions/src/main/resources/services/trinoui/365/service.xml
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<service role="TRINOUI" name="trino" version="365">
Review comment:
Missing the metadata information here. Without that piece of data, the Trino UI won't show up on the Knox Home page. Sample metadata section for Ranger:
https://github.com/apache/knox/blob/master/gateway-service-definitions/src/main/resources/services/rangerui/1.0.0/service.xml#L18-L23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] moresandeep commented on a change in pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
moresandeep commented on a change in pull request #541:
URL: https://github.com/apache/knox/pull/541#discussion_r818010392
##########
File path: gateway-service-definitions/src/main/resources/services/trinoui/365/service.xml
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<service role="TRINOUI" name="trino" version="365">
Review comment:
Good point @smolnar82!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] Flamingo93 closed pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
Flamingo93 closed pull request #541:
URL: https://github.com/apache/knox/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1067200487
I restarted the failed Tavis job, let's wait for a green build before merging this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] moresandeep commented on pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
moresandeep commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1061927588
@Flamingo93 checking in if you need any help with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] Flamingo93 commented on pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
Flamingo93 commented on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1066254493
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] Flamingo93 edited a comment on pull request #541: KNOX-2711 - Add trino ui support in service definition.
Posted by GitBox <gi...@apache.org>.
Flamingo93 edited a comment on pull request #541:
URL: https://github.com/apache/knox/pull/541#issuecomment-1066254493
>
@moresandeep @smolnar82 I have updated the screenshot and added metadata in service.xml, thank you for your guidance and advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org