You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/05 17:12:20 UTC

[GitHub] [httpcomponents-client] carterkozak opened a new pull request #235: HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

carterkozak opened a new pull request #235:
URL: https://github.com/apache/httpcomponents-client/pull/235


   https://issues.apache.org/jira/browse/HTTPCLIENT-2097


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-client] carterkozak commented on a change in pull request #235: HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

Posted by GitBox <gi...@apache.org>.
carterkozak commented on a change in pull request #235:
URL: https://github.com/apache/httpcomponents-client/pull/235#discussion_r449903943



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -252,7 +252,7 @@ public void completed(final PoolEntry<HttpRoute, ManagedAsyncClientConnection> p
 
                                     @Override
                                     public void execute(final Boolean result) {
-                                        if (result == Boolean.FALSE) {
+                                        if (!result) {

Review comment:
       I had initially written it this way to retain identical semantics:
   
   ```suggestion
                                           if (result != null && !result) {
   ```
   
   But it's unclear what null would mean if it's possible, and further analysis indicated that nothing passed null values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-client] michael-o commented on a change in pull request #235: HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #235:
URL: https://github.com/apache/httpcomponents-client/pull/235#discussion_r449903072



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -252,7 +252,7 @@ public void completed(final PoolEntry<HttpRoute, ManagedAsyncClientConnection> p
 
                                     @Override
                                     public void execute(final Boolean result) {
-                                        if (result == Boolean.FALSE) {
+                                        if (!result) {

Review comment:
       Can this actually lead to an NPE?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-client] ok2c merged pull request #235: HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #235:
URL: https://github.com/apache/httpcomponents-client/pull/235


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org