[jira] [Commented] (ATLAS-1898) Initial commit to feature-odf branch

["David Radley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064464#comment-16064464 ] 

David Radley commented on ATLAS-1898:
-------------------------------------

[~mandy_chessell] I have not tried to build this. Some initial comments from a quick scan of the patch

- I searched for IBM, I see references to IBM box, an IBM copyright, IBM db2 driver and the IBM jdk and IBM keystore. 
- I see from the build there is a dependancy on Java 7. For JanusGraph we are looking to move to Java 8. Do we know how difficult it will be to move up java levels? 
- I notice there is some sample data in bank-clients-short.csv - it looks like fake data - it does include what looks like ibm emails in. I think this needs changing   

> Initial commit to feature-odf branch
> ------------------------------------
>
>                 Key: ATLAS-1898
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1898
>             Project: Atlas
>          Issue Type: Sub-task
>          Components:  atlas-core
>            Reporter: Mandy Chessell
>              Labels: open-metadata
>         Attachments: 0001-ATLAS-1898-initial-commit-of-ODF.patch
>
>
> This is the initial commit of the ODF code.  The changes from the initial IBM code drop basically change java package names from com.ibm.iis.odf.* to org.apache.atlas.odf.*.  There are still references to IBM Box directories where deployment scripts look for the Atlas build.  these scripts need rethinking as we make the ODF a buildable component of Atlas



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)