You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/27 10:53:42 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #2188: Faster Null Path Selection in ArrayData Equality
tustvold opened a new issue, #2188:
URL: https://github.com/apache/arrow-rs/issues/2188
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
A number of the ArrayData equality comparisons have code along the lines of
```
let lhs_null_count = count_nulls(lhs.null_buffer(), lhs_start + lhs.offset(), len);
let rhs_null_count = count_nulls(rhs.null_buffer(), rhs_start + rhs.offset(), len);
if lhs_null_count == 0 && rhs_null_count == 0 {
// Optimised path that ignores nulls
}
```
These kernels aren't actually interested in the null count, purely if there are any nulls. It stands to reason this question can be answered more efficiently than computing the actual null count
**Describe the solution you'd like**
A solution that simply looks for the first 0 bit in the provided mask
**Describe alternatives you've considered**
**Additional context**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2188: Faster Null Path Selection in ArrayData Equality
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2188:
URL: https://github.com/apache/arrow-rs/issues/2188#issuecomment-1196635691
Additionally the null masks have already been compared at this point, and so we only need to check one of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2188: Faster Null Path Selection in ArrayData Equality
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2188:
URL: https://github.com/apache/arrow-rs/issues/2188#issuecomment-1196696743
Function added in https://github.com/apache/arrow-rs/pull/2194/files#diff-63d9e26acfe53e1a653e84debbd092b3f2d61c377fd9985fbc0b37b14dbed5b0R42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2188: Faster Null Path Selection in ArrayData Equality
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2188: Faster Null Path Selection in ArrayData Equality
URL: https://github.com/apache/arrow-rs/issues/2188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org