You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 16:08:23 UTC
[GitHub] [flink] dasbh opened a new pull request #10926: FLINK-15174 bind
all parameters for update SQL
dasbh opened a new pull request #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926
## What is the purpose of the change
*This pull request fixes the bug with binding setField for UpdateSQL *
Fixes issue https://issues.apache.org/jira/browse/FLINK-15728
## Brief change log
- *Added additional combined field to hold fieldtypes with pk types*
- * When using **UpsertWriterUsingInsertUpdateStatement** for update statement added additional field values for pk.
## Verifying this change
This change added tests and can be verified as follows:
- *Refactored JDBCUpsertOutputFormatTest to cover scenario of filedTypes specified*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:MANUAL TriggerID:577393301
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:MANUAL TriggerID:577393301
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:MANUAL TriggerID:577393301
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:MANUAL TriggerID:577393301
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbcc034ccf7d0727510688fd04022a5ed63d6e4c",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/145595403",
"triggerID" : "fbcc034ccf7d0727510688fd04022a5ed63d6e4c",
"triggerType" : "PUSH"
}, {
"hash" : "fbcc034ccf7d0727510688fd04022a5ed63d6e4c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560",
"triggerID" : "fbcc034ccf7d0727510688fd04022a5ed63d6e4c",
"triggerType" : "PUSH"
}, {
"hash" : "fbcc034ccf7d0727510688fd04022a5ed63d6e4c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/145595403",
"triggerID" : "577393301",
"triggerType" : "MANUAL"
}, {
"hash" : "fbcc034ccf7d0727510688fd04022a5ed63d6e4c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560",
"triggerID" : "577393301",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10926: FLINK-15174 bind all
parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577262210
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fbcc034ccf7d0727510688fd04022a5ed63d6e4c (Wed Jan 22 16:13:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:MANUAL TriggerID:577393301
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10926: FLINK-15174 bind all
parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dasbh commented on issue #10926: FLINK-15174 bind all
parameters for update SQL
Posted by GitBox <gi...@apache.org>.
dasbh commented on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577393301
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10926: FLINK-15174 bind
all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#issuecomment-577284854
<!--
Meta data
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145595403 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
Hash:fbcc034ccf7d0727510688fd04022a5ed63d6e4c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560 TriggerType:PUSH TriggerID:fbcc034ccf7d0727510688fd04022a5ed63d6e4c
-->
## CI report:
* fbcc034ccf7d0727510688fd04022a5ed63d6e4c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145595403) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10926:
FLINK-15174 bind all parameters for update SQL
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10926: FLINK-15174 bind all parameters for update SQL
URL: https://github.com/apache/flink/pull/10926#discussion_r375738757
##########
File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/writer/UpsertWriter.java
##########
@@ -260,5 +264,17 @@ public void close() throws SQLException {
updateStatement = null;
}
}
+
+ private int[] concatArray(int[] left, int[] right) {
Review comment:
Use `ArrayUtils.addAll`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services