You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/21 13:58:25 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #10560: ARROW-13127: [R] Valgrind nightly errors

jonkeane commented on a change in pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#discussion_r655401085



##########
File path: r/tests/testthat/test-RecordBatch.R
##########
@@ -571,7 +571,7 @@ test_that("RecordBatchReader to C-interface", {
 
   # export the RecordBatchReader via the C-interface
   stream_ptr <- allocate_arrow_array_stream()
-  on.exit(delete_arrow_array_stream(stream_ptr))
+  on.exit(delete_arrow_array_stream(stream_ptr), add = TRUE)

Review comment:
       yes, that's true — I put it here as a reminder that if we move it around / add another one we need to make sure to have it, though it is not strictly necessary. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org