[jira] [Commented] (MYNEWT-323) Newt - Build options precedence hierarchy

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYNEWT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369344#comment-15369344 ] 

ASF subversion and git services commented on MYNEWT-323:
--------------------------------------------------------

Commit a996d13f7d971ad6f4d35a8d2ee066002c55b5ae in incubator-mynewt-newt's branch refs/heads/develop from [~ccollins476]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-mynewt-newt.git;h=a996d13 ]

MYNEWT-323 Newt - Build flags precedence hierarchy

In the case of conflicting flags, the higher priority package's flag
wins.  Package priorities are assigned as follows (highest priority
first):
     * target
     * app (if present)
     * bsp
     * <library package>
     * compiler


> Newt - Build options precedence hierarchy
> -----------------------------------------
>
>                 Key: MYNEWT-323
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-323
>             Project: Mynewt
>          Issue Type: Bug
>          Components: Newt
>            Reporter: Christopher Collins
>             Fix For: v0_10_0
>
>
> When two packages specify conflicting build options, it is undefined which one takes effect.  Worse, if two packages specify conflicting cflags (e.g., "-DLOG_LEVEL=0" and "-DLOG_LEVEL=1"), gcc reports an error and aborts the build.
> We should enforce a well-defined precedence hierarchy.  I'm thinking something like this (lowest priority first):
> * Library
> * BSP
> * App
> * Target
> In the case of conflicting options, newt should discard all but the highest priority.  Newt would need to do some simple parsing of cflags to identity conflicts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)