[GitHub] [incubator-echarts] pissang commented on a change in pull request #12243: fix(pie): label not show when animation is disabled. fix #12110

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #12243: fix(pie): label not show when animation is disabled. fix #12110
URL: https://github.com/apache/incubator-echarts/pull/12243#discussion_r406577792
 
 

 ##########
 File path: src/chart/pie/PieView.js
 ##########
 @@ -180,31 +180,36 @@ piePieceProto.updateData = function (data, idx, firstCreate) {
     var withAnimation = !firstCreate && animationTypeUpdate === 'transition';
     this._updateLabel(data, idx, withAnimation);
 
-    this.highDownOnUpdate = (itemModel.get('hoverAnimation') && seriesModel.isAnimationEnabled())
+    this.highDownOnUpdate = !seriesModel.get('silent')
         ? function (fromState, toState) {
+            const hasAnimation = seriesModel.isAnimationEnabled();
             if (toState === 'emphasis') {
 
 Review comment:
   Needs to check `hoverAnimation` configuration here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org