[GitHub] [hive] deniskuzZ commented on a diff in pull request #4482: HIVE-27503: Support query iceberg tag

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #4482:
URL: https://github.com/apache/hive/pull/4482#discussion_r1268195686


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##########
@@ -443,11 +444,16 @@ public static Path getDumpPath(Path root, String dbName, String tableName) {
     return new Path(root, dbName);
   }
 
-  public static String getTableBranch(String branchName) {
-    Matcher branch = BRANCH.matcher(branchName);
-    if (branch.matches()) {
-      return branch.group(1);
+  public static String getTableSnapshotRef(String refName) {
+    Matcher ref = SNAPSHOT_REF.matcher(refName);
+    if (ref.matches()) {
+      return ref.group(1);
     }
     return null;
   }
+
+  public static Boolean checkTableTag(String refName) {

Review Comment:
   minor: isTableTag?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org