You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-issues@apache.org by "Jukka Zitting (Created) (JIRA)" <ji...@apache.org> on 2012/01/14 01:56:39 UTC
[jira] [Created] (INFRA-4331) Git pull request notifications broken
Git pull request notifications broken
-------------------------------------
Key: INFRA-4331
URL: https://issues.apache.org/jira/browse/INFRA-4331
Project: Infrastructure
Issue Type: Bug
Security Level: public (Regular issues)
Components: Git
Reporter: Jukka Zitting
Assignee: Jukka Zitting
The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (INFRA-4331) Git pull request notifications
broken
Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved INFRA-4331.
----------------------------------
Resolution: Fixed
Pull request notifications should now be working again.
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189974#comment-13189974 ]
Jukka Zitting commented on INFRA-4331:
--------------------------------------
The existing pull request notification mechanism [1] was based on forwarding incoming notification emails from Github to the respective dev@ mailing lists. However, it looks like after we turned the github.com/apache account into an organization, those email notifications stopped, and AFAICT there's no way to re-enable them. To fix this I think we need to set up a pull_request hook on Github and have the hook generate and send the email notifications.
[1] https://svn.apache.org/repos/infra/infrastructure/trunk/projects/git/bin/email-github.pl
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186056#comment-13186056 ]
Patrick Mueller commented on INFRA-4331:
----------------------------------------
I believe you're referring to this pull request, which I made earlier today:
https://github.com/apache/incubator-cordova-weinre/pull/1
Could this have anything to do with my email address? I created this commit through to the GitHub web pages, and my default email address is my yahoo one, though apache is also another email address associated with my account.
I'd never make a pull request like this for real - I'd always go through the command-line where my email address is set to the apache one.
Let me know if you'd like me to try again, with the apache address.
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (INFRA-4331) Git pull request notifications
broken
Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved INFRA-4331.
----------------------------------
Resolution: Fixed
Huh, finally fixed! Sorry about the delay on this.
Figuring out the ports system proved too complex given the limited amount of cycles I had for this, so I opted instead to just replace the use of Mail::Message with a direct call to sendmail with an explicitly formatted mail message as input. We may encounter some encoding and/or line wrapping issues with this approach, but at least the basic functionality works again.
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (INFRA-4331) Git pull request notifications
broken
Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved INFRA-4331.
----------------------------------
Resolution: Fixed
Good catch, thanks! Added -oi in commit b04d867.
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (INFRA-4331) Git pull request notifications
broken
Posted by "Jukka Zitting (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting reopened INFRA-4331:
----------------------------------
Yes, reopening. I hadn't installed some of the Perl modules used by the notification system properly so they got lost in an update.
Someone familiar with the FreeBSD ports system (or alternatively in setting up Perl modules as a part of a Git checkout) might be able to help here, as I'll be a bit busy with Incubator stuff for the next few days.
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (INFRA-4331) Git pull request notifications broken
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
#asfinfra IRC Bot closed INFRA-4331.
------------------------------------
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "#asfinfra IRC Bot (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227089#comment-13227089 ]
#asfinfra IRC Bot commented on INFRA-4331:
------------------------------------------
<danielsh> Do you need ports unblocked on the firewall or ports built on tb.a.o?
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211368#comment-13211368 ]
Jukka Zitting commented on INFRA-4331:
--------------------------------------
A restart was needed to activate an updated HMAC key, as without that the notifications were just being dropped. Now it's finally working as expected.
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (INFRA-4331) Git pull request notifications
broken
Posted by "#asfinfra IRC Bot (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
#asfinfra IRC Bot reopened INFRA-4331:
--------------------------------------
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224386#comment-13224386 ]
Shazron Abdullah commented on INFRA-4331:
-----------------------------------------
Seems Github pull request notifications are not working again - I searched through the callback-dev list, it never received an email regarding this pull request yesterday: https://github.com/apache/incubator-cordova-ios/pull/6
The last one received on the list was on Feb 27 2012, https://github.com/apache/incubator-cordova-android/pull/8
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "#asfinfra IRC Bot (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238622#comment-13238622 ]
#asfinfra IRC Bot commented on INFRA-4331:
------------------------------------------
<danielsh> Don't you need to dotstuff $data ? or pass -oi ?
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204101#comment-13204101 ]
Patrick Mueller commented on INFRA-4331:
----------------------------------------
Someone just sent me a link to this, but haven't looked at it yet;
http://alexking.org/blog/2011/11/28/not-getting-github-notifications
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4331) Git pull request notifications
broken
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188288#comment-13188288 ]
Shazron Abdullah commented on INFRA-4331:
-----------------------------------------
It happened with this pull-request as well from Becky Gibson https://github.com/apache/incubator-cordova-ios/pull/1
> Git pull request notifications broken
> -------------------------------------
>
> Key: INFRA-4331
> URL: https://issues.apache.org/jira/browse/INFRA-4331
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira