[jira] [Commented] (MESOS-1797) Packaged Zookeeper does not compile on OSX Yosemite

["Till Toenshoff (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167804#comment-14167804 ] 

Till Toenshoff commented on MESOS-1797:
---------------------------------------

[~xujyan] Would you be available for shepparding https://reviews.apache.org/r/26571 which should fix the above issue?
Note however that we still intend to wait for upstream to commit this patch into their project - hence the above RR would be a hotfix to prevent us from having to upgrade the bundled ZooKeeper altogether.

> Packaged Zookeeper does not compile on OSX Yosemite
> ---------------------------------------------------
>
>                 Key: MESOS-1797
>                 URL: https://issues.apache.org/jira/browse/MESOS-1797
>             Project: Mesos
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.20.0, 0.21.0, 0.19.1
>            Reporter: Dario Rexin
>            Priority: Minor
>
> I have been struggling with this for some time (due to my lack of knowledge about C compiler error messages) and finally found a way to make it compile. The problem is that Zookeeper defines a function `htonll` that is a builtin function in Yosemite. For me it worked to just remove this function, but as it needs to keep working on other systems as well, we would need some check for the OS version or if the function is already defined.
> Here are the links to the source:
> https://github.com/apache/zookeeper/blob/trunk/src/c/include/recordio.h#L73
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/recordio.c#L83-L97



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)