[GitHub] dubee commented on a change in pull request #3567: Activation result integration with log store SPI

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #3567: Activation result integration with log store SPI
URL: https://github.com/apache/incubator-openwhisk/pull/3567#discussion_r183509259
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala
 ##########
 @@ -85,13 +96,31 @@ class ElasticSearchLogStore(
   private def transcribeLogs(queryResult: EsSearchResult): ActivationLogs =
     ActivationLogs(queryResult.hits.hits.map(_.source.convertTo[UserLogEntry].toFormattedString))
 
+  private def transcribeResponse(queryResult: EsSearchResult): ActivationResponse = {
+    val res = queryResult.hits.hits.map(_.source.convertTo[UserResponseEntry].toFormattedString)
+
+    ActivationResponse.success(Some(res(0).parseJson.asJsObject))
 
 Review comment:
   Concerned about `res` being an array here. Need to at least check its length.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services