You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/25 20:12:17 UTC

Review Request 14937: Fixed regression in properly gc'ing completed executors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14937/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-737
    https://issues.apache.org/jira/browse/MESOS-737


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/slave/gc.cpp 711bbcbb93f97e59142fc005c69d6e07d5875ad4 
  src/slave/slave.hpp b9f9b046a0556266eba366a3587ceaaf45d2ad5f 
  src/slave/slave.cpp 243a8308c94063346bf5ea1f6624cad8dd72da3c 

Diff: https://reviews.apache.org/r/14937/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 14937: Fixed regression in properly gc'ing completed executors.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14937/#review27539
-----------------------------------------------------------

Ship it!


- Ben Mahler


On Oct. 25, 2013, 6:12 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14937/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 6:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-737
>     https://issues.apache.org/jira/browse/MESOS-737
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/gc.cpp 711bbcbb93f97e59142fc005c69d6e07d5875ad4 
>   src/slave/slave.hpp b9f9b046a0556266eba366a3587ceaaf45d2ad5f 
>   src/slave/slave.cpp 243a8308c94063346bf5ea1f6624cad8dd72da3c 
> 
> Diff: https://reviews.apache.org/r/14937/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 14937: Fixed regression in properly gc'ing completed executors.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14937/#review27540
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 25, 2013, 6:12 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14937/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 6:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-737
>     https://issues.apache.org/jira/browse/MESOS-737
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/gc.cpp 711bbcbb93f97e59142fc005c69d6e07d5875ad4 
>   src/slave/slave.hpp b9f9b046a0556266eba366a3587ceaaf45d2ad5f 
>   src/slave/slave.cpp 243a8308c94063346bf5ea1f6624cad8dd72da3c 
> 
> Diff: https://reviews.apache.org/r/14937/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>