You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2020/07/02 09:55:19 UTC
[myfaces-tobago] branch master updated (2216ac9 -> 62bf977)
This is an automated email from the ASF dual-hosted git repository.
lofwyr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git.
from 2216ac9 updating node libs to current versions
new d510dbe npm update
new 62bf977 id is missing in boolean-checkbox inside of a dropdown
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../renderkit/renderer/SelectBooleanCheckboxRenderer.java | 1 +
.../src/main/npm/package-lock.json | 12 ++++++------
.../tobago-theme-charlotteville/src/main/npm/package.json | 4 ++--
.../tobago-theme-roxborough/src/main/npm/package-lock.json | 12 ++++++------
.../tobago-theme-roxborough/src/main/npm/package.json | 4 ++--
.../tobago-theme-scarborough/src/main/npm/package-lock.json | 12 ++++++------
.../tobago-theme-scarborough/src/main/npm/package.json | 4 ++--
.../tobago-theme-speyside/src/main/npm/package-lock.json | 12 ++++++------
tobago-theme/tobago-theme-speyside/src/main/npm/package.json | 4 ++--
.../tobago-theme-standard/src/main/npm/package-lock.json | 12 ++++++------
tobago-theme/tobago-theme-standard/src/main/npm/package.json | 4 ++--
.../src/main/npm/ts/tobago-select-boolean-checkbox.ts | 11 ++++++-----
.../src/main/npm/ts/tobago-select-one-choice.ts | 3 ++-
.../src/main/npm/ts/tobago-select-one-listbox.ts | 3 ++-
14 files changed, 51 insertions(+), 47 deletions(-)
[myfaces-tobago] 02/02: id is missing in boolean-checkbox inside of
a dropdown
Posted by lo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lofwyr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit 62bf977a23a8b86e82d551faff3a5c16851e392b
Author: Udo Schnurpfeil <ud...@irian.eu>
AuthorDate: Thu Jul 2 11:55:01 2020 +0200
id is missing in boolean-checkbox inside of a dropdown
issue: TOBAGO-1633: TS refactoring
---
.../renderkit/renderer/SelectBooleanCheckboxRenderer.java | 1 +
.../src/main/npm/ts/tobago-select-boolean-checkbox.ts | 11 ++++++-----
.../src/main/npm/ts/tobago-select-one-choice.ts | 3 ++-
.../src/main/npm/ts/tobago-select-one-listbox.ts | 3 ++-
4 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java
index eea13da..aee06bf 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java
@@ -88,6 +88,7 @@ public class SelectBooleanCheckboxRenderer extends MessageLayoutRendererBase {
final Markup markup = select.getMarkup();
writer.startElement(getOuterHtmlTag());
+ writer.writeIdAttribute(clientId);
writer.writeClassAttribute(
getTobagoClass(),
getTobagoClass().createMarkup(markup),
diff --git a/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-boolean-checkbox.ts b/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-boolean-checkbox.ts
index a6a3593..88712d6 100644
--- a/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-boolean-checkbox.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-boolean-checkbox.ts
@@ -25,10 +25,10 @@ export class SelectBooleanCheckbox extends HTMLElement {
}
connectedCallback(): void {
- this.input.addEventListener("focus", Focus.setLastFocusId);
+ this.field.addEventListener("focus", Focus.setLastFocusId);
- if (this.input.readOnly) {
- this.input.addEventListener("click", preventClick);
+ if (this.field.readOnly) {
+ this.field.addEventListener("click", preventClick);
}
function preventClick(event: MouseEvent): void {
@@ -37,8 +37,9 @@ export class SelectBooleanCheckbox extends HTMLElement {
}
}
- get input(): HTMLInputElement {
- return this.querySelector(DomUtils.escapeClientId(this.id + DomUtils.SUB_COMPONENT_SEP + "field"));
+ get field(): HTMLInputElement {
+ const rootNode = this.getRootNode() as ShadowRoot | Document;
+ return rootNode.getElementById(this.id + DomUtils.SUB_COMPONENT_SEP + "field") as HTMLInputElement;
}
}
diff --git a/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-choice.ts b/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-choice.ts
index fff94da..9591482 100644
--- a/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-choice.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-choice.ts
@@ -28,7 +28,8 @@ class SelectOneChoice extends HTMLElement {
}
get field(): HTMLInputElement {
- return this.querySelector(DomUtils.escapeClientId(this.id + DomUtils.SUB_COMPONENT_SEP + "field"));
+ const rootNode = this.getRootNode() as ShadowRoot | Document;
+ return rootNode.getElementById(this.id + DomUtils.SUB_COMPONENT_SEP + "field") as HTMLInputElement;
}
}
diff --git a/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-listbox.ts b/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-listbox.ts
index 8b3eac8..35dd414 100644
--- a/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-listbox.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/npm/ts/tobago-select-one-listbox.ts
@@ -28,7 +28,8 @@ export class SelectOneListbox extends HTMLElement {
}
get field(): HTMLInputElement {
- return this.querySelector(DomUtils.escapeClientId(this.id + DomUtils.SUB_COMPONENT_SEP + "field"));
+ const rootNode = this.getRootNode() as ShadowRoot | Document;
+ return rootNode.getElementById(this.id + DomUtils.SUB_COMPONENT_SEP + "field") as HTMLInputElement;
}
}
[myfaces-tobago] 01/02: npm update
Posted by lo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lofwyr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit d510dbe35bd54ed48292e44004deb18ee0c0bfab
Author: Udo Schnurpfeil <ud...@irian.eu>
AuthorDate: Thu Jul 2 10:24:46 2020 +0200
npm update
---
.../src/main/npm/package-lock.json | 12 ++++++------
.../tobago-theme-charlotteville/src/main/npm/package.json | 4 ++--
.../tobago-theme-roxborough/src/main/npm/package-lock.json | 12 ++++++------
.../tobago-theme-roxborough/src/main/npm/package.json | 4 ++--
.../tobago-theme-scarborough/src/main/npm/package-lock.json | 12 ++++++------
.../tobago-theme-scarborough/src/main/npm/package.json | 4 ++--
.../tobago-theme-speyside/src/main/npm/package-lock.json | 12 ++++++------
tobago-theme/tobago-theme-speyside/src/main/npm/package.json | 4 ++--
.../tobago-theme-standard/src/main/npm/package-lock.json | 12 ++++++------
tobago-theme/tobago-theme-standard/src/main/npm/package.json | 4 ++--
10 files changed, 40 insertions(+), 40 deletions(-)
diff --git a/tobago-theme/tobago-theme-charlotteville/src/main/npm/package-lock.json b/tobago-theme/tobago-theme-charlotteville/src/main/npm/package-lock.json
index d4bac23..f66e683 100644
--- a/tobago-theme/tobago-theme-charlotteville/src/main/npm/package-lock.json
+++ b/tobago-theme/tobago-theme-charlotteville/src/main/npm/package-lock.json
@@ -3002,9 +3002,9 @@
}
},
"rollup": {
- "version": "2.18.1",
- "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.1.tgz",
- "integrity": "sha512-w4X77ADA+WTGlapC8Z6yggdJtODw3SBl6R2LSkA7ZW5MtdkgcB7sfaSD1UWyx8diXbMcGIb0eI9gCx/dyqOgNQ==",
+ "version": "2.18.2",
+ "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.2.tgz",
+ "integrity": "sha512-+mzyZhL9ZyLB3eHBISxRNTep9Z2qCuwXzAYkUbFyz7yNKaKH03MFKeiGOS1nv2uvPgDb4ASKv+FiS5mC4h5IFQ==",
"dev": true,
"requires": {
"fsevents": "~2.1.2"
@@ -3458,9 +3458,9 @@
"dev": true
},
"typescript": {
- "version": "3.9.5",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.5.tgz",
- "integrity": "sha512-hSAifV3k+i6lEoCJ2k6R2Z/rp/H3+8sdmcn5NrS3/3kE7+RyZXm9aqvxWqjEXHAd8b0pShatpcdMTvEdvAJltQ==",
+ "version": "3.9.6",
+ "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.6.tgz",
+ "integrity": "sha512-Pspx3oKAPJtjNwE92YS05HQoY7z2SFyOpHo9MqJor3BXAGNaPUs83CuVp9VISFkSjyRfiTpmKuAYGJB7S7hOxw==",
"dev": true
},
"universalify": {
diff --git a/tobago-theme/tobago-theme-charlotteville/src/main/npm/package.json b/tobago-theme/tobago-theme-charlotteville/src/main/npm/package.json
index 1adefb3..744366c 100644
--- a/tobago-theme/tobago-theme-charlotteville/src/main/npm/package.json
+++ b/tobago-theme/tobago-theme-charlotteville/src/main/npm/package.json
@@ -46,8 +46,8 @@
"npm-run-all": "^4.1.5",
"popper.js": "^1.16.1",
"postcss-cli": "^7.1.1",
- "rollup": "^2.18.1",
+ "rollup": "^2.18.2",
"tslint": "^6.1.2",
- "typescript": "^3.9.5"
+ "typescript": "^3.9.6"
}
}
diff --git a/tobago-theme/tobago-theme-roxborough/src/main/npm/package-lock.json b/tobago-theme/tobago-theme-roxborough/src/main/npm/package-lock.json
index e3c30ab..e587636 100644
--- a/tobago-theme/tobago-theme-roxborough/src/main/npm/package-lock.json
+++ b/tobago-theme/tobago-theme-roxborough/src/main/npm/package-lock.json
@@ -3002,9 +3002,9 @@
}
},
"rollup": {
- "version": "2.18.1",
- "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.1.tgz",
- "integrity": "sha512-w4X77ADA+WTGlapC8Z6yggdJtODw3SBl6R2LSkA7ZW5MtdkgcB7sfaSD1UWyx8diXbMcGIb0eI9gCx/dyqOgNQ==",
+ "version": "2.18.2",
+ "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.2.tgz",
+ "integrity": "sha512-+mzyZhL9ZyLB3eHBISxRNTep9Z2qCuwXzAYkUbFyz7yNKaKH03MFKeiGOS1nv2uvPgDb4ASKv+FiS5mC4h5IFQ==",
"dev": true,
"requires": {
"fsevents": "~2.1.2"
@@ -3458,9 +3458,9 @@
"dev": true
},
"typescript": {
- "version": "3.9.5",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.5.tgz",
- "integrity": "sha512-hSAifV3k+i6lEoCJ2k6R2Z/rp/H3+8sdmcn5NrS3/3kE7+RyZXm9aqvxWqjEXHAd8b0pShatpcdMTvEdvAJltQ==",
+ "version": "3.9.6",
+ "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.6.tgz",
+ "integrity": "sha512-Pspx3oKAPJtjNwE92YS05HQoY7z2SFyOpHo9MqJor3BXAGNaPUs83CuVp9VISFkSjyRfiTpmKuAYGJB7S7hOxw==",
"dev": true
},
"universalify": {
diff --git a/tobago-theme/tobago-theme-roxborough/src/main/npm/package.json b/tobago-theme/tobago-theme-roxborough/src/main/npm/package.json
index b552f94..4a1b7b5 100644
--- a/tobago-theme/tobago-theme-roxborough/src/main/npm/package.json
+++ b/tobago-theme/tobago-theme-roxborough/src/main/npm/package.json
@@ -46,8 +46,8 @@
"npm-run-all": "^4.1.5",
"popper.js": "^1.16.1",
"postcss-cli": "^7.1.1",
- "rollup": "^2.18.1",
+ "rollup": "^2.18.2",
"tslint": "^6.1.2",
- "typescript": "^3.9.5"
+ "typescript": "^3.9.6"
}
}
diff --git a/tobago-theme/tobago-theme-scarborough/src/main/npm/package-lock.json b/tobago-theme/tobago-theme-scarborough/src/main/npm/package-lock.json
index 6a9627c..eeeadbd 100644
--- a/tobago-theme/tobago-theme-scarborough/src/main/npm/package-lock.json
+++ b/tobago-theme/tobago-theme-scarborough/src/main/npm/package-lock.json
@@ -3002,9 +3002,9 @@
}
},
"rollup": {
- "version": "2.18.1",
- "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.1.tgz",
- "integrity": "sha512-w4X77ADA+WTGlapC8Z6yggdJtODw3SBl6R2LSkA7ZW5MtdkgcB7sfaSD1UWyx8diXbMcGIb0eI9gCx/dyqOgNQ==",
+ "version": "2.18.2",
+ "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.2.tgz",
+ "integrity": "sha512-+mzyZhL9ZyLB3eHBISxRNTep9Z2qCuwXzAYkUbFyz7yNKaKH03MFKeiGOS1nv2uvPgDb4ASKv+FiS5mC4h5IFQ==",
"dev": true,
"requires": {
"fsevents": "~2.1.2"
@@ -3458,9 +3458,9 @@
"dev": true
},
"typescript": {
- "version": "3.9.5",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.5.tgz",
- "integrity": "sha512-hSAifV3k+i6lEoCJ2k6R2Z/rp/H3+8sdmcn5NrS3/3kE7+RyZXm9aqvxWqjEXHAd8b0pShatpcdMTvEdvAJltQ==",
+ "version": "3.9.6",
+ "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.6.tgz",
+ "integrity": "sha512-Pspx3oKAPJtjNwE92YS05HQoY7z2SFyOpHo9MqJor3BXAGNaPUs83CuVp9VISFkSjyRfiTpmKuAYGJB7S7hOxw==",
"dev": true
},
"universalify": {
diff --git a/tobago-theme/tobago-theme-scarborough/src/main/npm/package.json b/tobago-theme/tobago-theme-scarborough/src/main/npm/package.json
index 7a9cdd8..bed02e6 100644
--- a/tobago-theme/tobago-theme-scarborough/src/main/npm/package.json
+++ b/tobago-theme/tobago-theme-scarborough/src/main/npm/package.json
@@ -46,8 +46,8 @@
"npm-run-all": "^4.1.5",
"popper.js": "^1.16.1",
"postcss-cli": "^7.1.1",
- "rollup": "^2.18.1",
+ "rollup": "^2.18.2",
"tslint": "^6.1.2",
- "typescript": "^3.9.5"
+ "typescript": "^3.9.6"
}
}
diff --git a/tobago-theme/tobago-theme-speyside/src/main/npm/package-lock.json b/tobago-theme/tobago-theme-speyside/src/main/npm/package-lock.json
index 54235b6..a60b4fd 100644
--- a/tobago-theme/tobago-theme-speyside/src/main/npm/package-lock.json
+++ b/tobago-theme/tobago-theme-speyside/src/main/npm/package-lock.json
@@ -3002,9 +3002,9 @@
}
},
"rollup": {
- "version": "2.18.1",
- "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.1.tgz",
- "integrity": "sha512-w4X77ADA+WTGlapC8Z6yggdJtODw3SBl6R2LSkA7ZW5MtdkgcB7sfaSD1UWyx8diXbMcGIb0eI9gCx/dyqOgNQ==",
+ "version": "2.18.2",
+ "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.2.tgz",
+ "integrity": "sha512-+mzyZhL9ZyLB3eHBISxRNTep9Z2qCuwXzAYkUbFyz7yNKaKH03MFKeiGOS1nv2uvPgDb4ASKv+FiS5mC4h5IFQ==",
"dev": true,
"requires": {
"fsevents": "~2.1.2"
@@ -3458,9 +3458,9 @@
"dev": true
},
"typescript": {
- "version": "3.9.5",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.5.tgz",
- "integrity": "sha512-hSAifV3k+i6lEoCJ2k6R2Z/rp/H3+8sdmcn5NrS3/3kE7+RyZXm9aqvxWqjEXHAd8b0pShatpcdMTvEdvAJltQ==",
+ "version": "3.9.6",
+ "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.6.tgz",
+ "integrity": "sha512-Pspx3oKAPJtjNwE92YS05HQoY7z2SFyOpHo9MqJor3BXAGNaPUs83CuVp9VISFkSjyRfiTpmKuAYGJB7S7hOxw==",
"dev": true
},
"universalify": {
diff --git a/tobago-theme/tobago-theme-speyside/src/main/npm/package.json b/tobago-theme/tobago-theme-speyside/src/main/npm/package.json
index 063f2e3..e38d2c3 100644
--- a/tobago-theme/tobago-theme-speyside/src/main/npm/package.json
+++ b/tobago-theme/tobago-theme-speyside/src/main/npm/package.json
@@ -46,8 +46,8 @@
"npm-run-all": "^4.1.5",
"popper.js": "^1.16.1",
"postcss-cli": "^7.1.1",
- "rollup": "^2.18.1",
+ "rollup": "^2.18.2",
"tslint": "^6.1.2",
- "typescript": "^3.9.5"
+ "typescript": "^3.9.6"
}
}
diff --git a/tobago-theme/tobago-theme-standard/src/main/npm/package-lock.json b/tobago-theme/tobago-theme-standard/src/main/npm/package-lock.json
index 9fd5b74..558ae64 100644
--- a/tobago-theme/tobago-theme-standard/src/main/npm/package-lock.json
+++ b/tobago-theme/tobago-theme-standard/src/main/npm/package-lock.json
@@ -7089,9 +7089,9 @@
}
},
"rollup": {
- "version": "2.18.1",
- "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.1.tgz",
- "integrity": "sha512-w4X77ADA+WTGlapC8Z6yggdJtODw3SBl6R2LSkA7ZW5MtdkgcB7sfaSD1UWyx8diXbMcGIb0eI9gCx/dyqOgNQ==",
+ "version": "2.18.2",
+ "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.18.2.tgz",
+ "integrity": "sha512-+mzyZhL9ZyLB3eHBISxRNTep9Z2qCuwXzAYkUbFyz7yNKaKH03MFKeiGOS1nv2uvPgDb4ASKv+FiS5mC4h5IFQ==",
"dev": true,
"requires": {
"fsevents": "~2.1.2"
@@ -8401,9 +8401,9 @@
}
},
"typescript": {
- "version": "3.9.5",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.5.tgz",
- "integrity": "sha512-hSAifV3k+i6lEoCJ2k6R2Z/rp/H3+8sdmcn5NrS3/3kE7+RyZXm9aqvxWqjEXHAd8b0pShatpcdMTvEdvAJltQ==",
+ "version": "3.9.6",
+ "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.6.tgz",
+ "integrity": "sha512-Pspx3oKAPJtjNwE92YS05HQoY7z2SFyOpHo9MqJor3BXAGNaPUs83CuVp9VISFkSjyRfiTpmKuAYGJB7S7hOxw==",
"dev": true
},
"uglify-js": {
diff --git a/tobago-theme/tobago-theme-standard/src/main/npm/package.json b/tobago-theme/tobago-theme-standard/src/main/npm/package.json
index aaf599d..1878937 100644
--- a/tobago-theme/tobago-theme-standard/src/main/npm/package.json
+++ b/tobago-theme/tobago-theme-standard/src/main/npm/package.json
@@ -56,11 +56,11 @@
"npm-run-all": "^4.1.5",
"popper.js": "^1.16.1",
"postcss-cli": "^7.1.1",
- "rollup": "^2.18.1",
+ "rollup": "^2.18.2",
"rollup-plugin-node-resolve": "^5.2.0",
"ts-jest": "^26.1.1",
"tslint": "^6.1.2",
- "typescript": "^3.9.5",
+ "typescript": "^3.9.6",
"uglify-js": "^3.10.0"
}
}