You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/24 04:55:17 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5360: ui: Go back for delete actions before querying async job
davidjumani opened a new pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360
### Description
Fixes https://github.com/apache/cloudstack/issues/5352
Navigates back in history before querying the result of an async job for any delete action
Querying the result leads to a page refresh which can cause an error if it is a delete action and the page has not been changed
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#issuecomment-905193337
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#issuecomment-904322006
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#discussion_r694562199
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -972,6 +972,9 @@ export default {
break
}
}
+ if ((action.icon === 'delete' || ['archiveEvents', 'archiveAlerts', 'unmanageVirtualMachine'].includes(action.api)) && this.dataView) {
Review comment:
Could this cause regression that you go back to previous screen and the action fails for some reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#discussion_r695401416
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -972,6 +972,9 @@ export default {
break
}
}
+ if ((action.icon === 'delete' || ['archiveEvents', 'archiveAlerts', 'unmanageVirtualMachine'].includes(action.api)) && this.dataView) {
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#issuecomment-905193428
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#issuecomment-904321748
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#discussion_r694564300
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -972,6 +972,9 @@ export default {
break
}
}
+ if ((action.icon === 'delete' || ['archiveEvents', 'archiveAlerts', 'unmanageVirtualMachine'].includes(action.api)) && this.dataView) {
+ this.$router.go(-1)
Review comment:
@davidjumani is it possible to check if previous page even exist? Like I can login with a VM details page redirect and then delete that VM. In that case will this take me back to VM list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#issuecomment-905196344
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5360 (SL-JID-562)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#discussion_r695401846
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -972,6 +972,9 @@ export default {
break
}
}
+ if ((action.icon === 'delete' || ['archiveEvents', 'archiveAlerts', 'unmanageVirtualMachine'].includes(action.api)) && this.dataView) {
+ this.$router.go(-1)
Review comment:
Will redirect to the dashboard. Right now vue doesn't support getting the history list so instead we need to use hooks for every navigation (to ensure we go up instead of to the dashboard) which will slow down the UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5360: ui: Go back for delete actions before querying async job
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5360:
URL: https://github.com/apache/cloudstack/pull/5360#issuecomment-904324119
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5360 (SL-JID-557)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org