[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6250: Add server configuration to lazy load files from deep storage.

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #6250:
URL: https://github.com/apache/incubator-pinot/pull/6250#discussion_r520910575



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -379,6 +382,16 @@ public BrokerResponse handleRequest(JsonNode request, @Nullable RequesterIdentit
       return new BrokerResponseNative(QueryException.getException(QueryException.BROKER_TIMEOUT_ERROR, errorMessage));
     }
 
+    // Validate the request
+    try {
+      validateNumSegments(offlineRoutingTable, realtimeRoutingTable, _querySegmentLimit);

Review comment:
       I suggest using a negative value as default, but yes. Please retain original behavior when it is not configured.
   
   Also, why do we want to skip at the query processing stage? Why not stop ingestion if the number of segments exceeds some "target" value (set on a per table basis).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org