You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/04/06 08:02:53 UTC
[GitHub] spark pull request #20906: [SPARK-23561][SS] Pull continuous processing out ...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20906#discussion_r179685434
--- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriter.java ---
@@ -29,14 +31,15 @@
* increasing numeric ID. This writer handles commits and aborts for each successive epoch.
*/
@InterfaceStability.Evolving
-public interface StreamWriter extends DataSourceWriter {
--- End diff --
By design we would create more mix-in interfaces for `DataSourceWriter`, like `SupportsWriteColumnarBatch`. If the `StreamWriter` doesn't extend `DataSourceWriter`, how shall we apply those mix-in interfaces for `StreamWriter`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org