You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/17 21:53:02 UTC
[GitHub] [maven-fluido-skin] michael-o opened a new pull request, #45: [MSKINS-101] Remove decorationModel/custom/publishDate from skin-macr…
michael-o opened a new pull request, #45:
URL: https://github.com/apache/maven-fluido-skin/pull/45
…os.vm
This can fully be replaced with MSITE-921. IF this custom value should be retained, I'd recommend to evaluate it *before* `$customDate` otherwise in reproducible builds it will be always set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] rfscholte commented on pull request #45: [MSKINS-101] Remove decorationModel/custom/publishDate from skin-macr…
Posted by "rfscholte (via GitHub)" <gi...@apache.org>.
rfscholte commented on PR #45:
URL: https://github.com/apache/maven-fluido-skin/pull/45#issuecomment-1404032333
I'm fine with this change. PublishDate is kind of related to reproducible builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #45: [MSKINS-101] Remove decorationModel/custom/publishDate from skin-macr…
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #45:
URL: https://github.com/apache/maven-fluido-skin/pull/45#issuecomment-1403384168
@rfscholte What is your opinion on the retention with the proposed change or is it not necessary at all from your PoV?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] asfgit merged pull request #45: [MSKINS-101] Remove decorationModel/custom/publishDate from skin-macr…
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #45:
URL: https://github.com/apache/maven-fluido-skin/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org