You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/31 23:13:57 UTC

[GitHub] [spark] srielau commented on pull request #38433: [SPARK-40943][SQL] Make the MSCK keyword optional in MSCK REPAIR TABLE commands

srielau commented on PR #38433:
URL: https://github.com/apache/spark/pull/38433#issuecomment-1297801930

   > If MySQL is the only DBMS for this syntax, I'm negative about this change because this PR only increases the chance of SQL incompatibility. Is there any other support cases?
   
   IMHO mySQL was onto something to not include MSCK (who is the chicken and who the egg here anyway?).
   It seems like everyone (e.g. IBM) just copied Hive to not rock the boat.
   
   Interestingly our own docs omit MSCK from the title (and the file name):
   https://spark.apache.org/docs/3.0.0-preview/sql-ref-syntax-ddl-repair-table.html
   
   It seems the only purpose of this keyword is to trip people up.
   As perhaps the most popular platform, we have the chance to lead here and make things easier.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org