You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Hwting (via GitHub)" <gi...@apache.org> on 2023/03/07 13:59:47 UTC
[GitHub] [apisix] Hwting opened a new issue, #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Hwting opened a new issue, #9031:
URL: https://github.com/apache/apisix/issues/9031
### Description
1.When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
### Environment
NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION
apisix apisix 1 2022-08-23 17:07:57.837975504 +0800 CST deployed apisix-0.11.0 2.15.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hwting commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "Hwting (via GitHub)" <gi...@apache.org>.
Hwting commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1460010689
@An-DJ
route：
/apisix/admin/routes/00000000000000003684
```
{"node":{"key":"\/apisix\/routes\/00000000000000003684","value":{"enable_websocket":true,"labels":{"pro":"xx","type":"whiteList"},"plugins":{"skywalking":{"_meta":{"disable":true}},"proxy-rewrite":{"regex_uri":["^\/xx\/(.*)","\/$1"]}},"update_time":1678241526,"uri":"\/xx\/xx\/xx\/websocket\/**","id":"00000000000000003687","status":1,"hosts":["api.xx.com"],"upstream_id":"50000000000000004","name":"xx-\/xx\/xx\/websocket\/**","create_time":1666354309}},"count":1,"action":"get"}
```
global:
/apisix/admin/global_rules
```
"skywalking":{"disable":false}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hwting commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "Hwting (via GitHub)" <gi...@apache.org>.
Hwting commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1459197521
> 你可以试试这个吗？
>
> ```
> {
> "plugins": {
> "skywalking": {
> "_meta": {
> "disable": true
> }
> }
> }
> }
> ```
also did not take effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1459145905
You can try this?
```
{
"plugins": {
"skywalking": {
"_meta": {
"disable": true
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1463289310
I can't reproduce this issue in my local env based on APISIX 3.2. Maybe you can follow my steps to check:
1. Create a Route with skywalking open:
```
curl -i "http://127.0.0.1:9180/apisix/admin/routes" -X PUT -d '
{
"id": "ip",
"uri": "/ip",
"plugins": {
"skywalking":{}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"httpbin.org:80": 1
}
}
}'
```
2. Create a global config with skywalking open:
```
curl http://127.0.0.1:9180/apisix/admin/plugin_configs/1 \
-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"plugins": {
"skywalking":{}
}
}'
```
3. Request the uri and there is a record in skywalking.
```
curl "http://localhost:9080/ip"
```
4. Close the skywalking in route level, then request again and check, there are **no new records**.
```
curl -i "http://127.0.0.1:9180/apisix/admin/routes/ip" -X PATCH -d '
{
"plugins": {
"skywalking": {
"_meta": {
"disable": true
}
}
}
}'
```
5. Reopen in route level and request again, there is a new record:
```
curl -i "http://127.0.0.1:9180/apisix/admin/routes/ip" -X PATCH -d '
{
"plugins": {
"skywalking": {
"_meta": {
"disable": false
}
}
}
}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hwting closed issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "Hwting (via GitHub)" <gi...@apache.org>.
Hwting closed issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
URL: https://github.com/apache/apisix/issues/9031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1459610859
@Hwting Could you plz show your global level config and route level config more in detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hwting commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "Hwting (via GitHub)" <gi...@apache.org>.
Hwting commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1465656672
#8603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hwting commented on issue #9031: help request: When the global skywalking plugin is enabled, disabling skywalking configuration at the route level does not take effect
Posted by "Hwting (via GitHub)" <gi...@apache.org>.
Hwting commented on issue #9031:
URL: https://github.com/apache/apisix/issues/9031#issuecomment-1465426767
I have no problem with APISIX/3.2.0, so this should be a 2.15.0 bug
> I can't reproduce this issue in my local env based on APISIX 3.2. Maybe you can follow my steps to check:
>
> 1. Create a Route with skywalking open:
>
> ```
> curl -i "http://127.0.0.1:9180/apisix/admin/routes" -X PUT -d '
> {
> "id": "ip",
> "uri": "/ip",
> "plugins": {
> "skywalking":{}
> },
> "upstream": {
> "type": "roundrobin",
> "nodes": {
> "httpbin.org:80": 1
> }
> }
> }'
> ```
>
> 2. Create a global config with skywalking open:
>
> ```
> curl http://127.0.0.1:9180/apisix/admin/plugin_configs/1 \
> -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
> {
> "plugins": {
> "skywalking":{}
> }
> }'
> ```
>
> 3. Request the uri and there is a record in skywalking.
>
> ```
> curl "http://localhost:9080/ip"
> ```
>
> 
>
> 4. Close the skywalking in route level, then request again and check, there are **no new records**.
>
> ```
> curl -i "http://127.0.0.1:9180/apisix/admin/routes/ip" -X PATCH -d '
> {
> "plugins": {
> "skywalking": {
> "_meta": {
> "disable": true
> }
> }
> }
> }'
> ```
>
> 5. Reopen in route level and request again, there is a new record:
>
> ```
> curl -i "http://127.0.0.1:9180/apisix/admin/routes/ip" -X PATCH -d '
> {
> "plugins": {
> "skywalking": {
> "_meta": {
> "disable": false
> }
> }
> }
> }'
> ```
>
> 
@An-DJ I have no problem with APISIX/3.2.0, so this should be a 2.15.0 bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org