You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Emond Papegaaij (JIRA)" <ji...@apache.org> on 2009/01/30 13:29:59 UTC

[jira] Created: (WICKET-2060) Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled

Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled
--------------------------------------------------------------------------

                 Key: WICKET-2060
                 URL: https://issues.apache.org/jira/browse/WICKET-2060
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.5
            Reporter: Emond Papegaaij


When setStripJavascriptCommentsAndWhitespace is enabled (for example in deployment mode), some javascript files get corrupted. For example, the following line (notice the 2 spaces after 'return')
return  this.__unbind__(type, fn);
is compacted to
return
this.__unbind__(type, fn);
which does not execute the unbind function.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2060) Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2060.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-RC3

seems to be fixed. See JavascriptStripperTest.java

> Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled
> --------------------------------------------------------------------------
>
>                 Key: WICKET-2060
>                 URL: https://issues.apache.org/jira/browse/WICKET-2060
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: Emond Papegaaij
>            Assignee: Matej Knopp
>             Fix For: 1.4-RC3
>
>         Attachments: jquery.hotkeys-0.7.8.js
>
>
> When setStripJavascriptCommentsAndWhitespace is enabled (for example in deployment mode), some javascript files get corrupted. For example, the following line (notice the 2 spaces after 'return')
> return  this.__unbind__(type, fn);
> is compacted to
> return
> this.__unbind__(type, fn);
> which does not execute the unbind function.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-2060) Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-2060:
-------------------------------------

    Assignee: Matej Knopp

> Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled
> --------------------------------------------------------------------------
>
>                 Key: WICKET-2060
>                 URL: https://issues.apache.org/jira/browse/WICKET-2060
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: Emond Papegaaij
>            Assignee: Matej Knopp
>         Attachments: jquery.hotkeys-0.7.8.js
>
>
> When setStripJavascriptCommentsAndWhitespace is enabled (for example in deployment mode), some javascript files get corrupted. For example, the following line (notice the 2 spaces after 'return')
> return  this.__unbind__(type, fn);
> is compacted to
> return
> this.__unbind__(type, fn);
> which does not execute the unbind function.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2060) Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled

Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij updated WICKET-2060:
------------------------------------

    Attachment: jquery.hotkeys-0.7.8.js

The file that triggers the problem (see line 85)

> Invalid javascript when setStripJavascriptCommentsAndWhitespace is enabled
> --------------------------------------------------------------------------
>
>                 Key: WICKET-2060
>                 URL: https://issues.apache.org/jira/browse/WICKET-2060
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: Emond Papegaaij
>         Attachments: jquery.hotkeys-0.7.8.js
>
>
> When setStripJavascriptCommentsAndWhitespace is enabled (for example in deployment mode), some javascript files get corrupted. For example, the following line (notice the 2 spaces after 'return')
> return  this.__unbind__(type, fn);
> is compacted to
> return
> this.__unbind__(type, fn);
> which does not execute the unbind function.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.