[GitHub] [jclouds] gaul commented on a change in pull request #118: Store the MPU ETag for the transient blobstore

[GitBox <gi...@apache.org>]

gaul commented on a change in pull request #118:
URL: https://github.com/apache/jclouds/pull/118#discussion_r682461456



##########
File path: blobstore/src/main/java/org/jclouds/blobstore/TransientStorageStrategy.java
##########
@@ -193,7 +195,14 @@ public String putBlob(final String containerName, final Blob blob, BlobAccess ac
          Closeables2.closeQuietly(input);
       }
 
-      Blob newBlob = createUpdatedCopyOfBlobInContainer(containerName, blob, payload, actualHashCode);
+      String eTag = null;
+      if (blob.getMetadata() != null) {
+         eTag = blob.getMetadata().getETag();
+      }
+      if (eTag == null || !MPU_ETAG_FORMAT.matcher(eTag).matches()) {

Review comment:
       Why does this need to sanity check the format?  Is there a danger to allowing an arbitrary input?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org