[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4015: [Authz] support catalog in DatabaseSpec and extract catalog for ResolvedNamespace and ResolvedDBObjectName of dsv2

[GitBox <gi...@apache.org>]

bowenliang123 commented on code in PR #4015:
URL: https://github.com/apache/kyuubi/pull/4015#discussion_r1057554086


##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/Descriptor.scala:
##########
@@ -151,7 +158,10 @@ case class FunctionDesc(
     val functionExtractor = functionExtractors(fieldExtractor)
     var function = functionExtractor(functionVal)
     if (function.database.isEmpty) {
-      function = function.copy(database = databaseDesc.map(_.extract(v)))
+      val maybeDatabase = databaseDesc.map(_.extract(v))

Review Comment:
   I think it's relevant as FunctionDesc using DataDesc, and now Database instead of pure string return from DataDesc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org