[GitHub] [lucene] zacharymorn commented on pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

[GitBox <gi...@apache.org>]

zacharymorn commented on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-861193051


   Thanks @jpountz for the review and suggestions! I have implemented the `TermVectors` idea in https://github.com/apache/lucene/pull/180/commits/0f8b0f49faab675b735c2c2f9713acdf17cfd7be and https://github.com/apache/lucene/pull/180/commits/c1cb5eb0753b4138ef0e4805db05510fae465ac0. 
   
   I noticed that upgrading the return type of the new method in `CodecReader` would fail a test case `TestFilterCodecReader#implTestDeclaredMethodsOverridden`, specifically at https://github.com/apache/lucene/blob/50607e0fb9090a1321093aca4117b6560c511af0/lucene/core/src/test/org/apache/lucene/index/TestFilterCodecReader.java#L59-L62. The reason being that the call `superClass.getDeclaredMethods` in that test would return both methods with different return types, so one of them would fail the equality check with the current method's return type. I think this issue is mostly about the test implementation though as it doesn't support Java's method return type change during inheritance, and I can look for a work around next.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org