You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2010/03/25 12:34:10 UTC
svn commit: r927351 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko
Date: Thu Mar 25 11:34:10 2010
New Revision: 927351
URL: http://svn.apache.org/viewvc?rev=927351&view=rev
Log:
votes and comment
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=927351&r1=927350&r2=927351&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 25 11:34:10 2010
@@ -165,7 +165,7 @@ PATCHES PROPOSED TO BACKPORT:
that it is, technically, a bug stopped me.
Simplified patch based on kkolinko's patch below
http://svn.apache.org/viewvc?view=revision&revision=927037
- +1: markt
+ +1: markt, kkolinko
-1:
I think it can be done more simply:
@@ -234,6 +234,12 @@ PATCHES PROPOSED TO BACKPORT:
and Catalina. Jasper should be independent.
The patch also needs to use the StringManager for i18n. I'm
working on an updated patch.
+ kkolinko - Jasper vs. Catalina dependency can be solved by moving the
+ new LockAwareURLClassLoader class to some other package.
+ Can go into o.a.tomcat.util.<something>. that is currently
+ packed into tomcat-coyote.jar in TC 6.0. The only
+ "dependency" on Catalina there is the name of the system
+ property that controls the behaviour.
* Correct SSL session timeout attribute name
http://people.apache.org/~markt/patches/2010-03-18-SslSessionTimeout.patch
@@ -243,7 +249,7 @@ PATCHES PROPOSED TO BACKPORT:
* Fix cluster regression, previous incorrect patch
http://svn.apache.org/viewvc?rev=924776&view=rev
https://issues.apache.org/bugzilla/show_bug.cgi?id=48934
- +1: fhanik, markt
+ +1: fhanik, markt, kkolinko
-1:
* Fix cross-context session expiration
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r927351 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
On 25/03/2010 19:26, Konstantin Kolinko wrote:
> 2010/3/25 Mark Thomas <ma...@apache.org>:
>> On 25/03/2010 11:34, kkolinko@apache.org wrote:
>>> @@ -234,6 +234,12 @@ PATCHES PROPOSED TO BACKPORT:
>>> and Catalina. Jasper should be independent.
>>> The patch also needs to use the StringManager for i18n. I'm
>>> working on an updated patch.
>>> + kkolinko - Jasper vs. Catalina dependency can be solved by moving the
>>> + new LockAwareURLClassLoader class to some other package.
>>> + Can go into o.a.tomcat.util.<something>. that is currently
>>> + packed into tomcat-coyote.jar in TC 6.0. The only
>>> + "dependency" on Catalina there is the name of the system
>>> + property that controls the behaviour.
>>
>> How about just sync'ing on this in 6.0.x and 5.5.x and experiementing
>> new options in Tomcat 7.
>>
>> In 7.0.x, the tomcat-api jar is shared between Catalina and Jasper but
>> for these classloader changes I'm leaning towards just using copy and
>> paste to keep things simple.
>>
>
> 1. I just noted several hour ago, that there is one more classloader that
> needs to inherit from LockAwareClassLoader:
> o.a.catalina.loader.StandardClassLoader
>
> So LockAwareClassLoader has to go into bootstrap.jar
That is going to get tricky to keep Jasper independent. Copy and paste
is looking better all the time ;)
> 2. For 5.5 I definitely would go with just sync(this). There is no point to
> target JRE 7 features there.
>
> 3. For 6.0 I am fine to go with sync(this) now.
OK. I'll apply that change to trunk and propose it for 6.0.x and 5.5.x.
> JRE 7.0 support is an enhancement and can be considered separately.
I'd be happy with somethign in 7.0.x, disabled by default that we could
back-port to 6.0.x once we were happy it was stable.
> I will attach my old patch to BZ 48903 for future reference.
Sounds good.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r927351 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/3/25 Mark Thomas <ma...@apache.org>:
> On 25/03/2010 11:34, kkolinko@apache.org wrote:
>> @@ -234,6 +234,12 @@ PATCHES PROPOSED TO BACKPORT:
>> and Catalina. Jasper should be independent.
>> The patch also needs to use the StringManager for i18n. I'm
>> working on an updated patch.
>> + kkolinko - Jasper vs. Catalina dependency can be solved by moving the
>> + new LockAwareURLClassLoader class to some other package.
>> + Can go into o.a.tomcat.util.<something>. that is currently
>> + packed into tomcat-coyote.jar in TC 6.0. The only
>> + "dependency" on Catalina there is the name of the system
>> + property that controls the behaviour.
>
> How about just sync'ing on this in 6.0.x and 5.5.x and experiementing
> new options in Tomcat 7.
>
> In 7.0.x, the tomcat-api jar is shared between Catalina and Jasper but
> for these classloader changes I'm leaning towards just using copy and
> paste to keep things simple.
>
1. I just noted several hour ago, that there is one more classloader that
needs to inherit from LockAwareClassLoader:
o.a.catalina.loader.StandardClassLoader
So LockAwareClassLoader has to go into bootstrap.jar
2. For 5.5 I definitely would go with just sync(this). There is no point to
target JRE 7 features there.
3. For 6.0 I am fine to go with sync(this) now.
JRE 7.0 support is an enhancement and can be considered separately.
I will attach my old patch to BZ 48903 for future reference.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r927351 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
On 25/03/2010 11:34, kkolinko@apache.org wrote:
> @@ -234,6 +234,12 @@ PATCHES PROPOSED TO BACKPORT:
> and Catalina. Jasper should be independent.
> The patch also needs to use the StringManager for i18n. I'm
> working on an updated patch.
> + kkolinko - Jasper vs. Catalina dependency can be solved by moving the
> + new LockAwareURLClassLoader class to some other package.
> + Can go into o.a.tomcat.util.<something>. that is currently
> + packed into tomcat-coyote.jar in TC 6.0. The only
> + "dependency" on Catalina there is the name of the system
> + property that controls the behaviour.
How about just sync'ing on this in 6.0.x and 5.5.x and experiementing
new options in Tomcat 7.
In 7.0.x, the tomcat-api jar is shared between Catalina and Jasper but
for these classloader changes I'm leaning towards just using copy and
paste to keep things simple.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org