[GitHub] [incubator-dolphinscheduler] chengshiwen commented on a change in pull request #4567: [Fix-4566][worker] worker-server logback partial logs are not printed

[GitBox <gi...@apache.org>]

chengshiwen commented on a change in pull request #4567:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4567#discussion_r564196002



##########
File path: dolphinscheduler-server/src/main/resources/logback-worker.xml
##########
@@ -56,10 +56,6 @@
     </appender>
     <appender name="WORKERLOGFILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
         <file>${log.base}/dolphinscheduler-worker.log</file>
-        <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
-            <level>INFO</level>
-        </filter>
-        <filter class="org.apache.dolphinscheduler.server.log.WorkerLogFilter"/>

Review comment:
       Why remove the ThresholdFilter configuration?
   In pr #4566, you mentioned that the log in `TaskKillProcessor.process` method does not exist in the worker.log file, and the method refered [code](https://github.com/apache/incubator-dolphinscheduler/blob/dev/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskKillProcessor.java#L85) just uses `logger.info`, the level of which is greater than or equal to `INFO` above removed code.
   Maybe you should check other code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org