You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ch...@apache.org on 2018/07/26 01:44:59 UTC

commons-rng git commit: accommodate for up to 4 re-runs of a failing test

Repository: commons-rng
Updated Branches:
  refs/heads/1.1 b400ab3d9 -> 1eb7ea49a


accommodate for up to 4 re-runs of a failing test


Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/1eb7ea49
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/1eb7ea49
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/1eb7ea49

Branch: refs/heads/1.1
Commit: 1eb7ea49a3e86fe6128361ec36f1cc424f64e1d8
Parents: b400ab3
Author: Rob Tompkins <ch...@gmail.com>
Authored: Wed Jul 25 21:44:46 2018 -0400
Committer: Rob Tompkins <ch...@gmail.com>
Committed: Wed Jul 25 21:44:46 2018 -0400

----------------------------------------------------------------------
 commons-rng-sampling/pom.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-rng/blob/1eb7ea49/commons-rng-sampling/pom.xml
----------------------------------------------------------------------
diff --git a/commons-rng-sampling/pom.xml b/commons-rng-sampling/pom.xml
index bd1fb0d..6d0a80a 100644
--- a/commons-rng-sampling/pom.xml
+++ b/commons-rng-sampling/pom.xml
@@ -66,4 +66,16 @@
     </dependency>
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <version>2.22.0</version>
+        <configuration>
+          <rerunFailingTestsCount>4</rerunFailingTestsCount>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
 </project>


Re: commons-rng git commit: accommodate for up to 4 re-runs of a failing test

Posted by Rob Tompkins <ch...@gmail.com>.

> On Jul 25, 2018, at 10:05 PM, Gilles <gi...@harfang.homelinux.org> wrote:
> 
> Hello Rob.
> 
> On Thu, 26 Jul 2018 01:44:59 +0000 (UTC), chtompki@apache.org <ma...@apache.org> wrote:
>> [...]
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/1eb7ea49/commons-rng-sampling/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/commons-rng-sampling/pom.xml b/commons-rng-sampling/pom.xml
>> index bd1fb0d..6d0a80a 100644
>> --- a/commons-rng-sampling/pom.xml
>> +++ b/commons-rng-sampling/pom.xml
>> @@ -66,4 +66,16 @@
>>     </dependency>
>>   </dependencies>
>> 
>> +  <build>
>> +    <plugins>
>> +      <plugin>
>> +        <artifactId>maven-surefire-plugin</artifactId>
>> +        <version>2.22.0</version>
>> +        <configuration>
>> +          <rerunFailingTestsCount>4</rerunFailingTestsCount>
>> +        </configuration>
>> +      </plugin>
>> +    </plugins>
>> +  </build>
>> +
>> </project>
> 
> Nice! [IIUC the number of "flakes" is per test, so allowing 2
> is already good as it's unlikely that the same sampler will
> fail twice in a row.]
> 
> Thanks for thinking about it and finding the workaround.

Right….I was psyched that I found that. :-)

-Rob

> 
> Regards,
> Gilles
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org <ma...@commons.apache.org>
> For additional commands, e-mail: dev-help@commons.apache.org <ma...@commons.apache.org>

Re: commons-rng git commit: accommodate for up to 4 re-runs of a failing test

Posted by Gilles <gi...@harfang.homelinux.org>.
Hello Rob.

On Thu, 26 Jul 2018 01:44:59 +0000 (UTC), chtompki@apache.org wrote:
> [...]
>
>
> 
> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/1eb7ea49/commons-rng-sampling/pom.xml
> 
> ----------------------------------------------------------------------
> diff --git a/commons-rng-sampling/pom.xml 
> b/commons-rng-sampling/pom.xml
> index bd1fb0d..6d0a80a 100644
> --- a/commons-rng-sampling/pom.xml
> +++ b/commons-rng-sampling/pom.xml
> @@ -66,4 +66,16 @@
>      </dependency>
>    </dependencies>
>
> +  <build>
> +    <plugins>
> +      <plugin>
> +        <artifactId>maven-surefire-plugin</artifactId>
> +        <version>2.22.0</version>
> +        <configuration>
> +          <rerunFailingTestsCount>4</rerunFailingTestsCount>
> +        </configuration>
> +      </plugin>
> +    </plugins>
> +  </build>
> +
>  </project>

Nice! [IIUC the number of "flakes" is per test, so allowing 2
is already good as it's unlikely that the same sampler will
fail twice in a row.]

Thanks for thinking about it and finding the workaround.

Regards,
Gilles



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org