You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 20:04:21 UTC

[GitHub] [arrow] kszucs opened a new pull request #7484: Use neutral wording for selecting and deselecting rules

kszucs opened a new pull request #7484:
URL: https://github.com/apache/arrow/pull/7484


   I went ahead and changed the obvious ones. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm closed pull request #7484: ARROW-9180: [Developer] Remove usage of whitelist, blacklist, slave, etc.

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7484:
URL: https://github.com/apache/arrow/pull/7484


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm commented on a change in pull request #7484: ARROW-9180: [Developer] Remove usage of whitelist, blacklist, slave, etc.

Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442547174



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11

Review comment:
       Can you open a PR into cpplint?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #7484: Use neutral wording for selecting and deselecting rules

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442477672



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11
   # brace initialization, there are more places where semicolons are
-  # required than not, so we use a whitelist approach to check these
-  # rather than a blacklist.  These are the places where "};" should
-  # be replaced by just "}":
+  # required than not, so we use explicitly list the allowed rules

Review comment:
       It's rarely updated so I think it's ok to edit it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #7484: ARROW-9180: [Developer] Remove usage of whitelist, blacklist, slave, etc.

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442910168



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11

Review comment:
       Will do




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #7484: Use neutral wording for selecting and deselecting rules

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442477868



##########
File path: dev/archery/archery/cli.py
##########
@@ -318,9 +318,9 @@ def lint(ctx, src, fix, iwyu_all, **checks):
 @click.option("--src", metavar="<arrow_src>", default=None,
               callback=validate_arrow_sources,
               help="Specify Arrow source directory")
-@click.option("--whitelist", "-w", help="Allow only these rules")
-@click.option("--blacklist", "-b", help="Disallow these rules")
-def numpydoc(src, symbols, whitelist, blacklist):
+@click.option("--enable-rule", "-e", multiple=True, help="Allow only these rules")

Review comment:
       No, there are not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #7484: ARROW-9180: [Developer] Remove usage of whitelist, blacklist, slave, etc.

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r443032066



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11

Review comment:
       Done: https://github.com/google/styleguide/pull/562




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7484: Use neutral wording for selecting and deselecting rules

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#issuecomment-646283739


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #7484: Use neutral wording for selecting and deselecting rules

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442475340



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11
   # brace initialization, there are more places where semicolons are
-  # required than not, so we use a whitelist approach to check these
-  # rather than a blacklist.  These are the places where "};" should
-  # be replaced by just "}":
+  # required than not, so we use explicitly list the allowed rules

Review comment:
       This file is vendored; is it ok for us to edit it? (I'll note that https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py still says whitelist/blacklist)

##########
File path: dev/archery/archery/cli.py
##########
@@ -318,9 +318,9 @@ def lint(ctx, src, fix, iwyu_all, **checks):
 @click.option("--src", metavar="<arrow_src>", default=None,
               callback=validate_arrow_sources,
               help="Specify Arrow source directory")
-@click.option("--whitelist", "-w", help="Allow only these rules")
-@click.option("--blacklist", "-b", help="Disallow these rules")
-def numpydoc(src, symbols, whitelist, blacklist):
+@click.option("--enable-rule", "-e", multiple=True, help="Allow only these rules")

Review comment:
       Are there docs that need to be updated for this change? Crossbow/GHA jobs that need to be called differently?

##########
File path: cpp/build-support/cpplint.py
##########
@@ -4066,11 +4066,11 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
     #  - INTERFACE_DEF
     #  - EXCLUSIVE_LOCKS_REQUIRED, SHARED_LOCKS_REQUIRED, LOCKS_EXCLUDED:
     #
-    # We implement a whitelist of safe macros instead of a blacklist of
+    # We implement a list of of safe macros instead of a list of

Review comment:
       ```suggestion
       # We implement a list of safe macros instead of a list of
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7484: ARROW-9180: [Developer] Remove usage of whitelist, blacklist, slave, etc.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#issuecomment-646342530


   https://issues.apache.org/jira/browse/ARROW-9180


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org