You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Joerg Schaible (JIRA)" <ji...@apache.org> on 2007/02/09 22:14:05 UTC

[jira] Created: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
--------------------------------------------------------------------

                 Key: LANG-320
                 URL: https://issues.apache.org/jira/browse/LANG-320
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.2
            Reporter: Joerg Schaible


LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Closed: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-320.
------------------------------

    Resolution: Won't Fix

> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>             Fix For: Known Issue
>
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated LANG-320:
-------------------------------

    Fix Version/s:     (was: 3.0)
                   Known Issue

> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>             Fix For: Known Issue
>
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471837 ] 

Rahul Akolkar commented on LANG-320:
------------------------------------

Might want to consider guarding such tests where expected results are vendor-specific (potentially LANG-318 as well, though haven't looked at that closely) based on the vendor information. [lang] itself provides SystemUtils.JAVA_VENDOR etc. to make the information trivially accessible.


> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Closed: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-320.
------------------------------

    Resolution: Fixed

I've fixed this by changing both of the assertions to only assert that the results contain, rather than that the results equal. This should allow things to be less problematic when a JVM adds a language, and it seems a lot less likely that the JVM would remove a language.

Fixed in r508733.

> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>             Fix For: 3.0
>
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated LANG-320:
-------------------------------

    Fix Version/s: 3.0

Should be fixed. We had the same problem with US_en when US_es turned up (or something like that). The solution then was to change the test to not use one with a dupe. Maybe we need a better test instead. Investigate for 3.0.

> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>             Fix For: 3.0
>
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Reopened: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell reopened LANG-320:
--------------------------------


> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>             Fix For: 3.0
>
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (LANG-320) LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions

Posted by "Joerg Schaible (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471849 ] 

Joerg Schaible commented on LANG-320:
-------------------------------------

This test in special has not to do much with the vendor. Sun might deliver the cy_GB local with every new patch and then the test will fails also. LANG-318 is different though.

> LocaleUtilsTest fails with IBM JDK 1.5.0 because of false assuptions
> --------------------------------------------------------------------
>
>                 Key: LANG-320
>                 URL: https://issues.apache.org/jira/browse/LANG-320
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Joerg Schaible
>
> LocaleUtilsTest.testLanguagesByCountry makes the assumption, that within the JDK there is only one language defined for GB: en. This is not true for the IBM JDK 1.5.0 that also knows about cy_GB i.e. Welsh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org