[GitHub] [flink] JingsongLi commented on issue #10989: [FLINK-15840][table-planner-blink] ClassCastException is thrown when use tEnv.from for temp/catalog table

[GitBox <gi...@apache.org>]

JingsongLi commented on issue #10989: [FLINK-15840][table-planner-blink] ClassCastException is thrown when use tEnv.from for temp/catalog table
URL: https://github.com/apache/flink/pull/10989#issuecomment-581088372
 
 
   Hi @wuchong , you can take a look to `FlinkPlannerImpl`, it needs many things:
   ```
   config: FrameworkConfig,
   catalogReaderSupplier: JFunction[JBoolean, CalciteCatalogReader],
   typeFactory: FlinkTypeFactory,
   cluster: RelOptCluster
   ```
   `TableScanRule` also can not find these arguments.
   
   And I don't think this is a good way. `FlinkToRelContext` is bad idea to me. Just fix `TableScanRule` looks like a very temporary fix, and we don't know if there is another `ToRelContext`.
   
   In 1.11, there is another plan to support computed column in table api, as I said above, it is considered to separate the compute column translation and complete translation in the parser stage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services