[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6329: Fix table cache logic in pinot-broker

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-pinot/pull/6329#discussion_r537810333



##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -1307,7 +1308,8 @@ public void testCaseInsensitivity() {
 
     for (String query : queries) {
       try {
-        postQuery(query);
+        JsonNode response = postSqlQuery(query);
+        Assert.assertTrue(response.get("numSegmentsProcessed").asLong() >= 1L, query + " failed");

Review comment:
       You can directly use `assertTrue()`, same for other places

##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -1307,7 +1308,8 @@ public void testCaseInsensitivity() {
 
     for (String query : queries) {
       try {
-        postQuery(query);
+        JsonNode response = postSqlQuery(query);

Review comment:
       Can you please check why it does not apply to pql? It should apply to both pql and sql

##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1002,7 +1002,7 @@ private String getActualColumnName(String rawTableName, String columnName,
         columnName = splits[1];
       }
       if (columnNameMap != null) {
-        return columnNameMap.getOrDefault(columnName, columnName);
+        return columnNameMap.getOrDefault(columnName.toLowerCase(), columnName);

Review comment:
       Good catch, but how the the test pass before?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org