You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/03/06 11:39:39 UTC
[GitHub] [arrow] AlenkaF commented on a diff in pull request #34463: GH-32619: [Python][Docs] Include options for PyArrow build explicitly
AlenkaF commented on code in PR #34463:
URL: https://github.com/apache/arrow/pull/34463#discussion_r1126291178
##########
docs/source/developers/python.rst:
##########
@@ -586,6 +586,86 @@ Caveats
The Plasma component is not supported on Windows.
+Relevant components and environment variables
+=============================================
+
+List of relevant Arrow CMake flags and corresponding environment variables
+to be used when building PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - CMAKE_BUILD_TYPE
+ - PYARROW_BUILD_TYPE (release, dbug or relwithdebinfo)
+ * - ARROW_GCS
+ - PYARROW_WITH_GCS
+ * - ARROW_S3
+ - PYARROW_WITH_S3
+ * - ARROW_HDFS
+ - PYARROW_WITH_HDFS
+ * - ARROW_CUDA
+ - PYARROW_WITH_CUDA
+ * - ARROW_SUBSTRAIT
+ - PYARROW_WITH_SUBSTRAIT
+ * - ARROW_FLIGHT
+ - PYARROW_WITH_FLIGHT
+ * - ARROW_DATASET
+ - PYARROW_WITH_DATASET
+ * - ARROW_PARQUET
+ - PYARROW_WITH_PARQUET
+ * - PARQUET_REQUIRE_ENCRYPTION
+ - PYARROW_WITH_PARQUET_ENCRYPTION
+ * - ARROW_PLASMA
+ - PYARROW_WITH_PLASMA
+ * - ARROW_TENSORFLOW
+ - PYARROW_WITH_TENSORFLOW
+ * - ARROW_ORC
+ - PYARROW_WITH_ORC
+ * - ARROW_GANDIVA
+ - PYARROW_WITH_GANDIVA
+
+List of relevant environment variables that can also be used to build
+PyArrow are:
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - PyArrow environment variable
+ - Description
+ * - PYARROW_CMAKE_GENERATOR
+ - Example: 'Visual Studio 15 2017 Win64'
+ * - PYARROW_CMAKE_OPTIONS
+ - Extra CMake and Arrow options (ex. ``"-DARROW_SIMD_LEVEL"``,
+ ``"-DCMAKE_OSX_ARCHITECTURES"``)
+ * - PYARROW_BOOST_NAMESPACE
+ - Name of install folder for boost (if different from 'boost')
+ * - PYARROW_CXXFLAGS
+ - Extra cxx flags
+ * - PYARROW_WITH_STATIC_PARQUET
+ - Rely on parquet shared libraries where relevant, default OFF
+ * - PYARROW_WITH_STATIC_BOOST
+ - Rely on Boost shared libraries on linking static parquet, default OFF
Review Comment:
There is some inconsistency if I am reading the code correctly.
`PYARROW_WITH_STATIC_PARQUET` and `PYARROW_WITH_STATIC_BOOST` are set to `false`/`OFF` (`0`) in setup.py:
https://github.com/apache/arrow/blob/e69a53e9ee8a1c14b9556c1009c12903d89a594b/python/setup.py#L174-L179
but the corresponding flags are set to `ON` in CMakeLists.txt:
https://github.com/apache/arrow/blob/e69a53e9ee8a1c14b9556c1009c12903d89a594b/python/setup.py#L309-L312
https://github.com/apache/arrow/blob/e69a53e9ee8a1c14b9556c1009c12903d89a594b/python/CMakeLists.txt#L119-L123
Will create an issue for it if I am not mistaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org