You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ma...@apache.org on 2015/08/17 10:31:15 UTC
incubator-kylin git commit: KYLIN-926 removing job meta in /tmp
Repository: incubator-kylin
Updated Branches:
refs/heads/KYLIN-926 [created] cadb6c2fe
KYLIN-926 removing job meta in /tmp
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/cadb6c2f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/cadb6c2f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/cadb6c2f
Branch: refs/heads/KYLIN-926
Commit: cadb6c2fe4ddfc746cc77b2611c28efa548c269c
Parents: b549275
Author: honma <ho...@ebay.com>
Authored: Mon Aug 17 16:32:10 2015 +0800
Committer: honma <ho...@ebay.com>
Committed: Mon Aug 17 16:32:10 2015 +0800
----------------------------------------------------------------------
.../org/apache/kylin/job/hadoop/AbstractHadoopJob.java | 1 +
.../kylin/job/hadoop/cube/FactDistinctColumnsJob.java | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/cadb6c2f/job/src/main/java/org/apache/kylin/job/hadoop/AbstractHadoopJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/hadoop/AbstractHadoopJob.java b/job/src/main/java/org/apache/kylin/job/hadoop/AbstractHadoopJob.java
index 61a8e48..3535f61 100644
--- a/job/src/main/java/org/apache/kylin/job/hadoop/AbstractHadoopJob.java
+++ b/job/src/main/java/org/apache/kylin/job/hadoop/AbstractHadoopJob.java
@@ -257,6 +257,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
protected void cleanupTempConfFile(Configuration conf) {
String tempMetaFileString = conf.get("tmpfiles");
+ logger.info("cleaning tempMetaFileString " + tempMetaFileString);
if (tempMetaFileString != null) {
File tempMetaFile = new File(tempMetaFileString);
if (tempMetaFile.exists()) {
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/cadb6c2f/job/src/main/java/org/apache/kylin/job/hadoop/cube/FactDistinctColumnsJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/hadoop/cube/FactDistinctColumnsJob.java b/job/src/main/java/org/apache/kylin/job/hadoop/cube/FactDistinctColumnsJob.java
index 6e2b467..e13e011 100644
--- a/job/src/main/java/org/apache/kylin/job/hadoop/cube/FactDistinctColumnsJob.java
+++ b/job/src/main/java/org/apache/kylin/job/hadoop/cube/FactDistinctColumnsJob.java
@@ -18,29 +18,28 @@
package org.apache.kylin.job.hadoop.cube;
+import java.io.IOException;
+
import org.apache.commons.cli.Options;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.io.NullWritable;
import org.apache.hadoop.io.ShortWritable;
import org.apache.hadoop.io.Text;
+import org.apache.hadoop.mapreduce.Job;
import org.apache.hadoop.mapreduce.lib.output.FileOutputFormat;
import org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat;
-import org.apache.hadoop.mapreduce.Job;
import org.apache.hadoop.util.ToolRunner;
import org.apache.hive.hcatalog.mapreduce.HCatInputFormat;
import org.apache.kylin.common.KylinConfig;
import org.apache.kylin.common.util.HadoopUtil;
import org.apache.kylin.cube.CubeInstance;
import org.apache.kylin.cube.CubeManager;
-import org.apache.kylin.cube.model.CubeDesc;
import org.apache.kylin.job.constant.BatchConstants;
import org.apache.kylin.job.hadoop.AbstractHadoopJob;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.io.IOException;
-
/**
* @author yangli9
*/
@@ -88,8 +87,9 @@ public class FactDistinctColumnsJob extends AbstractHadoopJob {
printUsage(options);
throw e;
} finally {
- if (job != null)
+ if (job != null) {
cleanupTempConfFile(job.getConfiguration());
+ }
}
}