You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org> on 2023/02/16 21:24:43 UTC
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19508
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
In the MetastoreServiceHandler class, the 'add_write_notification_log_in_batch'
API implementation is missing which is causing test failures. This needs to be
fixed by adding implementation of the 'add_write_notification_log_in_batch'
api in the MetastoreServiceHandler class
Testing:
Added a test in the 'test_hms_apis()' to verify that the
'add_write_notification_log_in_batch' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19508/1
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 May 2023 07:03:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19508/2/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19508/2/tests/custom_cluster/test_metastore_service.py@1015
PS2, Line 1015: l
flake8: F841 local variable 'logBatchResp' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 19:30:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@1015
PS3, Line 1015: l
flake8: F841 local variable 'logBatchResp' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 12:38:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/12411/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 19:43:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 5:
Csaba Ringhofer, Daniel Becker -- Can you please do another round of review on this patch?
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 21:07:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/12389/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 21:37:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9
PS2, Line 9:
> I think that Impala could also use this new API:
This API implementation in HMS only supports Insert and reload events from Impala. We'll have to change this HMS implementation every single time a new API is introduced (along with impala changes). I don't think that would be ideal.
http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG@9
PS3, Line 9: In the MetastoreServiceHandler class, the
> We use a line length limit of 72 columns in the commit message.
Ack
http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java:
http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2415
PS3, Line 2415: WriteN
> Indentation in case of line continuation should be 4.
Ack
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@988
PS3, Line 988: MetastoreServiceHandler in impala can talk to HMS through these APIs):
> Nit: some of this line fits on the previous line (max line length is 90).
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Mar 2023 05:35:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/12416/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 12:48:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9331/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 May 2023 16:23:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/19508/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java:
http://gerrit.cloudera.org:8080/#/c/19508/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2418
PS1, Line 2418: .add_write_notification_log_in_batch(batchRequest);
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1012
PS1, Line 1012: ;
flake8: E703 statement ends with a semicolon
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1013
PS1, Line 1013: t
flake8: E999 SyntaxError: invalid syntax
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1013
PS1, Line 1013:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1013
PS1, Line 1013: WriteNotificationLogBatchRequest rqst =
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1014
PS1, Line 1014: n
flake8: E113 unexpected indentation
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1014
PS1, Line 1014:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1014
PS1, Line 1014: new WriteNotificationLogBatchRequest("hive", "default",
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1015
PS1, Line 1015: ;
flake8: E703 statement ends with a semicolon
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 21:25:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9
PS2, Line 9:
> This API implementation in HMS only supports Insert and reload events from
add_write_notification_log_in_batch seems to be the batched version of add_write_notification_log, an API we already use (through IMetaStoreClient.addWriteNotificationLog() ). So I thought that we only need to change Impala, not Hive to use a more efficient API.
Checked IMetaStoreClient, and addWriteNotificationLogInBatch() is added to it.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Mar 2023 09:42:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG@9
PS3, Line 9: In the MetastoreServiceHandler class, the 'add_write_notification_log_in_batch'
We use a line length limit of 72 columns in the commit message.
http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java:
http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2415
PS3, Line 2415:
Indentation in case of line continuation should be 4.
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@988
PS3, Line 988: reachable from impala (so that MetastoreServiceHandler in impala
Nit: some of this line fits on the previous line (max line length is 90).
http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@1017
PS3, Line 1017: # The HMS api add_write_notification_log_in_batch is reachable.
Could also start this line with "If the above call is successful", like in the other test.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 16:24:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19508
to look at the new patch set (#2).
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
In the MetastoreServiceHandler class, the 'add_write_notification_log_in_batch'
API implementation is missing which is causing test failures. This needs to be
fixed by adding implementation of the 'add_write_notification_log_in_batch'
api in the MetastoreServiceHandler class
Testing:
Added a test in the 'test_hms_apis()' to verify that the
'add_write_notification_log_in_batch' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19508/2
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19508
to look at the new patch set (#3).
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
In the MetastoreServiceHandler class, the 'add_write_notification_log_in_batch'
API implementation is missing which is causing test failures. This needs to be
fixed by adding implementation of the 'add_write_notification_log_in_batch'
api in the MetastoreServiceHandler class
Testing:
Added a test in the 'test_hms_apis()' to verify that the
'add_write_notification_log_in_batch' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19508/3
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
In the MetastoreServiceHandler class, the 'add_write_notification_log_
in_batch' API implementation is missing which is causing test failures.
This needs to be fixed by adding implementation of the 'add_write_
notification_log_in_batch' api in the MetastoreServiceHandler class
Testing:
Added a test in the 'test_hms_apis()' to verify that the 'add_write_
notification_log_in_batch' api in HMS is reachable from impala. The
same test can be used in the future to test newly added apis in HMS.
Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Reviewed-on: http://gerrit.cloudera.org:8080/19508
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 24 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 8
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG@9
PS4, Line 9: In the MetastoreServiceHandler class, the
This is now 42, the limit is 72.
http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG@19
PS4, Line 19: 'add_write_notification_log_in_batch' api in HMS is reachable from impala.
Line too long (74 vs 72).
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Mar 2023 09:20:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19508
to look at the new patch set (#4).
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
In the MetastoreServiceHandler class, the
'add_write_notification_log_in_batch' API
implementation is missing which is causing
test failures. This needs to be fixed by
adding implementation of the
'add_write_notification_log_in_batch'
api in the MetastoreServiceHandler class
Testing:
Added a test in the 'test_hms_apis()' to verify that the
'add_write_notification_log_in_batch' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19508/4
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9
PS2, Line 9: add_write_notification_log_
> add_write_notification_log_in_batch seems to be the batched version of add_
That's a good suggestion. I don't we would use this API at all in Impala. Since MetastoreServiceHandler class extends AbstractThriftHiveMetastore class and every time a new API is introduced in AbstractThriftHiveMetastore class we'll have to define it in MetastoreServiceHandler class.
http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG@9
PS4, Line 9: In the MetastoreServiceHandler class, the 'add_write_notification_log_
> This is now 42, the limit is 72.
Ack
http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG@19
PS4, Line 19: Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
> Line too long (74 vs 72).
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Mar 2023 14:48:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 May 2023 16:23:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 May 2023 08:18:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19508
to look at the new patch set (#5).
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
In the MetastoreServiceHandler class, the 'add_write_notification_log_
in_batch' API implementation is missing which is causing test failures.
This needs to be fixed by adding implementation of the 'add_write_
notification_log_in_batch' api in the MetastoreServiceHandler class
Testing:
Added a test in the 'test_hms_apis()' to verify that the 'add_write_
notification_log_in_batch' api in HMS is reachable from impala. The
same test can be used in the future to test newly added apis in HMS.
Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19508/5
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 1: Code-Review+1
Changes lgtm. Could you address the various formatting comments ?
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 20:49:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 6: Code-Review+2
upgrading to +2 and starting GVO
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 May 2023 16:22:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 May 2023 21:39:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9
PS2, Line 9: add_write_notification_log_in_batch
I think that Impala could also use this new API:
https://github.com/apache/impala/blob/88a7538af79afc19233cdfe3220e3c25e7edd16d/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java#L430
I don't mean to start using it in this patch, just curious if the API to speed sending the write events in ACID tables is available now.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 10:28:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................
Patch Set 4:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/12602/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Mar 2023 05:47:09 +0000
Gerrit-HasComments: No