[jira] [Commented] (CALCITE-3340) Make TUMBLE be accepted as an operand for COLLECTION_TABLE(TABLE syntax) in validator

["Rui Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928130#comment-16928130 ] 

Rui Wang commented on CALCITE-3340:
-----------------------------------

By treating TUMBLE the same as OTHER_FUNCTION during registration, and remove DESCRIPTOR because we haven't decided how to support it, I ended with an exception:

Cannot apply 'TUMBLE' to arguments of type 'TUMBLE(<RECORDTYPE(TIMESTAMP(0) ROWTIME, INTEGER ID, VARCHAR(10) PRODUCT, INTEGER UNITS)>, <INTERVAL MINUTE>)'. Supported form(s): 'TUMBLE(<DATETIME>, <DATETIME_INTERVAL>)'
'TUMBLE(<DATETIME>, <DATETIME_INTERVAL>, <TIME>)

This is understandable and the resolution seems to be a new signature  for TUMBLE to allow RECORDTYPE as the first parameter.

> Make TUMBLE be accepted as an operand for COLLECTION_TABLE(TABLE syntax) in validator
> -------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3340
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3340
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>
> For query:
> SELECT *
> FROM TABLE(TUMBLE(
> TABLE ORDERS,
> DESCRIPTOR(ROWTIME),
> INTERVAL '10' MINUTE))
> (note reuse TUMBLE operator than use a new unresolved one)
> Calcite validator will does a step to do registration and "TABLE(TUMBLE(...))" will hit [1], where "TUMBLE(...)" will be passed to [2] again but there is no matching  Sqlkind handling for "TUMBLE" (note that TUMBLE's node kind is TUMBLE). 
> It seems we should support TUMBLE in [2]. The details of how to support it needs a bit more discussion and prototyping.
> [1]: https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2244
> [2]:https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2031



--
This message was sent by Atlassian Jira
(v8.3.2#803003)